unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 350918e7be: Adjust x_display_set_last_user_time for Xlib sign-extension
Date: Tue, 22 Nov 2022 21:16:02 +0800	[thread overview]
Message-ID: <87zgcj2kq5.fsf@yahoo.com> (raw)
In-Reply-To: <87cz9f9loe.fsf@gmail.com> (Robert Pluim's message of "Tue, 22 Nov 2022 14:13:37 +0100")

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Tue, 22 Nov 2022 07:58:19 -0500 (EST), Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:
>     Po Lu> +  /* Time can be sign extended if retrieved from a client message.
>     Po Lu> +     Make sure it is always 32 bits, or systems with 64-bit longs
>     Po Lu> +     will crash after 24 days of X server uptime.  (bug#59480) */
>     Po Lu> +  time &= X_ULONG_MAX;
>     Po Lu> +
>     Po Lu>  #ifdef ENABLE_CHECKING
>     Po Lu>    eassert (time <= X_ULONG_MAX);
>     Po Lu>  #endif
>
> You could even remove the `eassert' now, but itʼs a minor thing.
>
> Robert

Right, I missed that.



      reply	other threads:[~2022-11-22 13:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166912189923.20568.14093477497390803497@vcs2.savannah.gnu.org>
     [not found] ` <20221122125819.904D2C0E4B5@vcs2.savannah.gnu.org>
2022-11-22 13:13   ` master 350918e7be: Adjust x_display_set_last_user_time for Xlib sign-extension Robert Pluim
2022-11-22 13:16     ` Po Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgcj2kq5.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).