From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop Date: Wed, 08 Mar 2023 10:24:36 +0800 Message-ID: <87zg8onfob.fsf@yahoo.com> References: <167821009581.14664.5608674978571454819@vcs2.savannah.gnu.org> <20230307172816.2D56BC13915@vcs2.savannah.gnu.org> <877cvsozn5.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11622"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 08 03:25:30 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZjUf-0002v1-Vr for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Mar 2023 03:25:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZjU4-0004I1-5V; Tue, 07 Mar 2023 21:24:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZjU2-0004Hn-IA for emacs-devel@gnu.org; Tue, 07 Mar 2023 21:24:50 -0500 Original-Received: from sonic307-3.consmr.mail.bf2.yahoo.com ([74.6.134.42]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZjU0-0001K9-SH for emacs-devel@gnu.org; Tue, 07 Mar 2023 21:24:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678242284; bh=7F7snNghHM8uOOecaIf9O4v6Cr355xxYLYppnFh4FuM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=GopyMkSUFBICr3T7Bpg68hTuQtWeLqEPOHVbg7d+4rdubXFtcJCMoSlv7SPF4HO7SauHRnN89q77gSieYAc5Hw1f2g+SUxlOlz8l3t1y71cwJlY3tMDLRvjBXORPzjVsMSG13u1kECPWUJyPP83gHMHCZXcbNbCjxyGwXVjj8f0wIQPn0KUuSA+JWU0G/M23jDDAWWbwNPErwi1XHPZFN09jvpv1le/KS7zzVUD11IM2TJy+4/MZLr0nuJuuY3bMs7EhYmaPr9TkhoEQiD5xn/tSIcGWGWpDN4AY34y9WNVmd8Hqy28WA2eoKrkyo0T+oWNF5zSt9UoelzuZCyW5iw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678242284; bh=/xnk95BHStaRUkWnWYA/bDMaauYVdUurOArqQGG7Xpw=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=MLtzRZbKSMMepCKUF2g/8MLaaZFNnMST2phTMaDxpiCC3j40ydhtXnixoHSIfLY5I5OR1S6Vvb3oyNhwex3V8tLJ0mC82XnG0D9fpv0NS6y1bC5O1tHtdS+56iSrDoQ3i7lk3reDS1+siLsVbnYjBO9ZoqyC4hHVS41QYJbHAJxe7g+p4591f7JZd5v1bh0PcMc+UHCXBiC0lfIwujRbERxC2QvBxcbhJyW0T017/6buAobOjVK+20obr+D3/bF2kiVObSG9hj4TTTOCWrHzHmxXDXc6HrpdGTQ9b8S37FWxqYnZJMLKGhDCCRWP14BloOAqR7aXFkrVAvXQI7rMKQ== X-YMail-OSG: TJrov1AVM1lDbdq2aLdhPaNF_uyy1DChp3Adwv0zS4EUp3hIwj4fEJxqdKE8bHg wz_46f.eweiMA7OywbdUmIMEaEB.rSkguk8Ij6ptD86JSu0AKqcdALCEZ6Go2fanu7IEth6xlzsm T_ghdCBUX5MF3X32yIIpcKcL3w4LSosCE7M3lD6q.QGrdyQOrDncfZ2t67bQFbecF9RnJV8kUjZP NU361Y2LSryNIhqAdjzqKpd5RV8KxHkhbKvmJYRyAPomQU6bggD8fK6rKAp_tHZgoWfnZNsY_B3r LviiX9jOsdc_WJRqQS4Et0kyYXI7tZFAfrZ2x9rrPAsJp1lQchiOE3_nZe_duyfpsefHdL5B52Us fCKpEYhaiuWI8Lb1O4.Ih_H6x2ShCsucU7Ip_UD4JzAEeQvgibwl9qjNYYKyFeggymZrJ0T4WS4A ROqlrFzqIsNX6hfwME1ox.aQWIOfGiQVLwXT8fRFlxAYb_r.cJp97LnRKWPKIgK9zNPulJ5fXtWc l0eIOzmmFkvj8nhiXQsb_CQh3mlKs9M8JHK59bJfFY133ZgcHUWUkwuePXFWwN2A.BlH2bylr.j1 hFOeUC6R7zIeAJyTImAAETcftCTSx2tdKq7ZtRu4807c6PrQegqdETX6Yecu4qVYW68DOhGLvXJ2 jruxly1.ReRNm9UlfkWOyvWLnZv0Au2StIvzJjarwI.R757QXJBh44SSvBV_Kno.kToc6He65Q4L ZMqH0trzboUfanhRieeSUyVIp3FKLVkD6OCpWybbwhkP7c5MzV9kMwnfj4CeB_SeHbQi4tfIQPkJ 95uPBHUisUtkaqFdOxlPuBRFBk0kmU_WHOkKvdFrVq X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.bf2.yahoo.com with HTTP; Wed, 8 Mar 2023 02:24:44 +0000 Original-Received: by hermes--production-sg3-67c57bccff-d4fzt (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 74611eecd3b55dcb4db89eb9cd37b578; Wed, 08 Mar 2023 02:24:40 +0000 (UTC) In-Reply-To: (Ulrich Mueller's message of "Wed, 08 Mar 2023 03:14:08 +0100") X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=74.6.134.42; envelope-from=luangruo@yahoo.com; helo=sonic307-3.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304101 Archived-At: Ulrich Mueller writes: > Then the desktop file won't work, obviously. The problem is that > ${PARAMETER//PATTERN/STRING} substitution is not available in POSIX > parameter expansion. So with POSIX sh, an external program (e.g. sed) > would have to be called. > > The long term solution (suggested by Stefan Monnier) might be to add > a --funcall option to emacsclient. Then there would be no need for a > shell wrapper, in the first place. > > Should the Makefile skip installation of emacsclient-mail.desktop > when bash isn't available on the system? Could we install this change not on emacs-29, but on master? I don't think the problem it solves is severe, nor a regression from Emacs 28. It is rather a minor nusiance with certain URLs.