From: Emanuel Berg <incal@dataswamp.org>
To: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require
Date: Wed, 31 Jan 2024 15:51:35 +0100 [thread overview]
Message-ID: <87zfwlbloo.fsf@dataswamp.org> (raw)
In-Reply-To: jwvplximou5.fsf-monnier+emacs@gnu.org
Stefan Monnier wrote:
>> Does it mean that you would not recommend moving
>> declare-function inside function if that function does not
>> have require?
>
> The `declare-function` tells the compiler "trust me, this
> function will exist by the time we reach this point in the
> code".
>
> Often as a programmer, what makes me confident to say such
> a thing is that I just did a `require`, but not always [...]
If you have a lexical let-closure (a `let' or `let*' at
top-level and a `defun' within it) and byte-compile the file,
the byte-compiler will warn the function isn't known to be
defined it it is refered to in the code. So after the defun
one can use `declare-function', either inside the closure or
after it.
I have mentioned it a couple of times so I know it is
well-known, and probably a bug or area of possible improvement
in the byte-compiler.
--
underground experts united
https://dataswamp.org/~incal
prev parent reply other threads:[~2024-01-31 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org>
[not found] ` <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org>
2024-01-30 12:41 ` [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Stefan Monnier
2024-01-30 15:19 ` Ihor Radchenko
2024-01-30 17:31 ` Stefan Monnier
2024-01-30 18:59 ` Ihor Radchenko
2024-01-30 21:41 ` Stefan Monnier
2024-01-30 22:11 ` Ihor Radchenko
2024-01-30 22:57 ` Stefan Monnier
2024-01-31 14:51 ` Emanuel Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfwlbloo.fsf@dataswamp.org \
--to=incal@dataswamp.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).