From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?S=C5=82awomir?= Grochowski Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: [DISCUSSION] "quick-help" popup for org-columns (column view) Date: Thu, 02 May 2024 20:04:33 +0200 Message-ID: <87zft8t7im.fsf@gmail.com> References: <87a5oayblv.fsf@gmail.com> <87jzlxro68.fsf@localhost> <87zfu6b4w3.fsf@gmail.com> <86jzl91zrd.fsf@gnu.org> <87frvwl2wv.fsf@gmail.com> <87plv02rez.fsf@posteo.net> <87cyqzllbx.fsf@gmail.com> <87o7ahmxnj.fsf@posteo.net> <87msq12blu.fsf@gmail.com> <87cyqwmmkb.fsf@posteo.net> <87v84l3bfx.fsf@posteo.net> <87wmoy94wc.fsf@gmail.com> <87o7a9lqh1.fsf@posteo.net> <87mspqe6gc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27125"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 02 20:05:34 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2aoH-0006tq-Kn for ged-emacs-devel@m.gmane-mx.org; Thu, 02 May 2024 20:05:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2anW-000105-Ih; Thu, 02 May 2024 14:04:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2anU-0000zI-85; Thu, 02 May 2024 14:04:44 -0400 Original-Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2anS-0002Sm-Lo; Thu, 02 May 2024 14:04:43 -0400 Original-Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a51a7d4466bso944449866b.2; Thu, 02 May 2024 11:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714673080; x=1715277880; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=knuPqJInc6HswFAy4jtYX2U2meJabNr9TVY69GjxFi4=; b=Urwcvz9iXEb2eDe4Awbw+rH6Bj2JSGnodcU8ZIM940w5zurCo5kCLOxYvHKkWzvR5l NGe84cMoErZZo9hZ7aVxP0ckp/rIPICohS4V36UuGsIXmwjXysNHNqGebd53OG6QZyhu 8p8egXX1UXI+OjKBzdSi7iCKyqkc3QXvMPqIWBGTdpKhP8kCkcgiS2o6KtZ+GbE4TrtW PhKxOxKA/a1gNCjV40ntJulAOfV5YXcwYiM/+u2YEDdZGvW2dY/OtX7dMQ+5iRdK/Ftn JZtfqejb1ElyXSq3UhHEqQmfLy9T42sPgR5Ju5suRwXtvXQABoJBwlOVUcYJ69YaWR0U aVrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714673080; x=1715277880; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=knuPqJInc6HswFAy4jtYX2U2meJabNr9TVY69GjxFi4=; b=FGfrZBoS6ZfpTpdw4VTAF1RQ+xifG+jDnq1b0j2hCug+TRjjsaL5yDctOfZB06yO0F 9HaASdyPHVQ6ludlOloSYhpmMLF+8qa6Jk2Rj6Y0ZFKmzd0++1vZtcN4P1R0dyjXVYME yHcLTOITZk8bIhjpdoQvf/0PcFSauRGtECwRaJu0dIHGJ4J4HaEiSwfvelzdHa+uudFm u4UCvQ/fw6iGOjYsgtkdDHs2t/zxJcFnt4Gu9Y0dSWEhsxD/kgi1aB0Ucgolwy40kIIi Wu8bFoFbI8JxFCZLTBU47FM22izct15Gnmdt5sXHiIcYudR7TrjqXGJM5ZwhoD1yoSr5 2QbQ== X-Forwarded-Encrypted: i=1; AJvYcCXDDHEHhB/KUzd6t33BysK6JQyOdNTFwrCYPaUZLivE7KLw5h3mm1JU8O1dqSZ9igb1T0JmnQZ4By6FJTnDLBa/BLCV7gBNzUSmZRRPgDWOdNdsVsgoVZYjZ6Q= X-Gm-Message-State: AOJu0YxKo/hURGLStX2dpplAc/PHPgh3RsaBY9BLGWTLvcy2bk/sBIy5 f/6QEkNb0+v8JT3MmrEdijlP8a+aMMkY9LKWGLNok2fexqHspuuCsNwDFQ== X-Google-Smtp-Source: AGHT+IF6hvRACFHrgiA4wBNb7k3OW+O/WgxMBO6wlLu6nJNbq5EV5SMUDCcL9wDDmupoOcdW5K53ew== X-Received: by 2002:a50:9e62:0:b0:572:9d8a:20f4 with SMTP id z89-20020a509e62000000b005729d8a20f4mr112362ede.32.1714673079565; Thu, 02 May 2024 11:04:39 -0700 (PDT) Original-Received: from windows (83.6.116.35.ipv4.supernova.orange.pl. [83.6.116.35]) by smtp.gmail.com with ESMTPSA id er21-20020a056402449500b005726e5e8765sm757533edb.3.2024.05.02.11.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 11:04:39 -0700 (PDT) In-Reply-To: <87mspqe6gc.fsf@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=slawomir.grochowski@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318604 gmane.emacs.orgmode:161420 Archived-At: Hi Philip,=20 what's your opinion about this change? I understand it's a low-level hack, but maybe you can advise on how to do i= t better?=20 S=C5=82awomir Grochowski writes: > That's great idea. I tried with this code: > > (message "Toggle display of quick-help buffer using %s." > (propertize (key-description (this-command-keys)) 'face 'help-ke= y-binding 'font-lock-face 'help-key-binding)) > > And it works perfectly.=20 > But I would like 'help-quick' for org-columns to be bind to other > keybinding: "?" not "C-h C-q". > > Because now it's like this: > > 1. invoke the command using "?" keybinding: > > (defun org-columns-help-quick-toggle () > (interactive) > (let ((help-quick-sections org-columns-help-quick-sections) > (help-quick-use-map org-columns-map)) > (help-quick-toggle))) > > (org-defkey org-columns-map "?" #'org-columns-help-quick-toggle) > > 2. 'help-quick' for org-columns buffer will appear with the message: > "Toggle display of quick-help buffer using C-h C-q." > > So this is misleading. > Because pressing 'C-h C-q' will close the buffer but pressing it again > will show 'help-quick' buffer and not 'help-quick' for org-columns buffer. > > Therefore, I think that to use a different keybinding we need to modify > the code. > Or am I missing something? --=20 Slawomir Grochowski