From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes Date: Tue, 09 Jul 2024 22:16:44 +0800 Message-ID: <87zfqqzm43.fsf@yahoo.com> References: <172010929191.25736.12718952666511242363@vcs2.savannah.gnu.org> <20240704160812.55782C2BC72@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37652"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Pip Cet , emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 09 16:17:57 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRBfI-0009YU-Iq for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jul 2024 16:17:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRBeg-0002an-4Q; Tue, 09 Jul 2024 10:17:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRBee-0002aY-JY for emacs-devel@gnu.org; Tue, 09 Jul 2024 10:17:16 -0400 Original-Received: from sonic309-20.consmr.mail.ne1.yahoo.com ([66.163.184.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRBec-0000tk-IF for emacs-devel@gnu.org; Tue, 09 Jul 2024 10:17:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1720534631; bh=VzqYD+O8BNCzbsu++Pb9AFdYqd8xZdKU1+2amiJiqjQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=kWEmosCA+VBkPxKIdMy26O4TE7qTI94QNVuyVF4+1WEbFgQcxE+KeplGVKx3TuS0deXMlb/oaWZkcYMWLydUkk2IxiWcfJS96hxRdmprtqb0bFol+Q6NA7lb7iTafoSiaYR+9ON6Uk0ggj7CizAnpsSx1a/5BdA0XdyYAyeiGJ8083Y9O0ETZf81CMxKTE4rwakgYS20dbQ6qWxdb/6VDAksz9W+De6YKMJ6bcDRkHiOg3iXa7vyQARwE4o9ukIM1Tlfj/2Myy5MJmFoQBq7yGpD0cvntb1fM7yDDzTH4CBJgCeUBo42h/rubltDhlT+y9SPY930qSck2r4fayn9Vw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1720534631; bh=xp1Dstk9boSiSBNNky0grFdZFsvHyiD6q/cLmkGsJO2=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=rvdGKVHJhiK7wN9tyrVcacxTbMjQaR0NQ3hJDtY4hgBt+wQ3eUC/yF2cZs5QqURlKt78hzjkGappXcJ4L7LYcg+iS0RBRzhEyqcMq3xTMPmsd1VFaUQdymLPo1srtd/LIZnKgT8askQ4g1WCCNQa06lOjnnKoTWqoFvM3hvp8MbWI6FYWcFpUdmJwAwBhjIDT9qerlOspbw1bzKiWlnPDUFh4FpcUTmiGOPJGpf8fztZ0NPmp7bASFqBeD84XcjPmueXCssq8fAT5kv37Js0cR+oTKKg8WKqfMiPsW8XqSoQSjsGs308jzNlfoytFOYAE1NPUURZ3cP9Nopj0r+6iQ== X-YMail-OSG: ZfJrHrgVM1mGBtCK6zXt_nootiK67DbqlmrdAe24heKw00TkRaoOSojitT4x7tA VhTKT6DQhITJhh.LKiT..0L1znYvSq3sUzPhYpi.tDZQuZTcib4Wtvllj728iRCq98MudxVnB7LG 9wvtqvI870byw.6LJcGCrMOFq6tZGDG89lVDsMHPRwib5JXlUJoSYk9omXGuPx66ZGKxKoGyHQbO ir.5.Cssg2BjEdVaa3StYfstBuqstX2N5lWw7bLEGge.4Bk7NT.SwLWmHB0z3nN9..j9B.gSt01h ZsSySiH3etBy5sdOlR6P9vtv5N2vknEQBFIzo11DyqlBa3yrxi4hg7f2wvumkjAGP5BKaP4Z9ZJK K4leggYYN.q0Ig3LRhLWr2U.pTLU2eVyLdj6nQu3u9ocQlCkM7WDf9w_r9v2j8np0_D6T8D_vJKH a36DT9tvzXlTUJxtW_DSZXWpXTTeoz.b7_VUPAfLADiy9eGDnnOoG10nuC4NONTQEtcjf4CrVHOp JWA0Q0beYyExcKrilNuP7icrCdvgE0QFN6vEl.QdbCWJXfgB20U4IWXEQ3TJWUemRyJ2fd3BhNEu GZkc_UFvlkVkaPHyhEIoj2RZsi5PcXGtXMXaMD5iD_9.8gU3pdEEBgYZVjm3_wxZu4Z9b8u7dO8g x6tJAesfoUE.orM2PpES9_y7jTJvU.tpi.QkBVdvlDNAm1mEZ_6cNDIkjptLdBAbkFq4Wz2bj94f MP_qu_m2OeUdC8jE5DZZEUf9ylL0xVGIQCPTXypDpYA1c5KK2CXsDMO0LRM6uM4Xlxi1s6MpAsvF dsM4bsQLr69q6KC2DfqN0.txloPcDYyKntgBC6F0XQ X-Sonic-MF: X-Sonic-ID: 53778ecc-f70e-45da-8665-85fc32ea9cda Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Tue, 9 Jul 2024 14:17:11 +0000 Original-Received: by hermes--production-sg3-7b469d9f6-rjqq2 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 242285cf6171a5c6a72fb34533eabdef; Tue, 09 Jul 2024 14:17:05 +0000 (UTC) In-Reply-To: (Andrea Corallo's message of "Tue, 09 Jul 2024 10:12:54 -0400") X-Mailer: WebService/1.1.22464 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.146; envelope-from=luangruo@yahoo.com; helo=sonic309-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321566 Archived-At: Andrea Corallo writes: > Pip Cet writes: > >> On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo wrote: >>> Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes: >>> >>> > branch: scratch/igc >>> > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372 >>> > Author: Pip Cet pipcet@protonmail.com >>> > Commit: Pip Cet pipcet@protonmail.com >>> > >>> > Fix GTK-related MPS crashes >>> > >>> > * src/gtkutil.c (free_glib_user_data): New function. >>> > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS. >>> > (qttip_cb, xg_create_frame_widgets) >>> > (xg_create_frame_outer_widgets, create_dialog) >>> > (make_cl_data, unref_cl_data, xg_mark_data) >>> > (menuitem_highlight_callback, xg_create_one_menuitem) >>> > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets) >>> > (draw_page, xg_print_frames_dialog, xg_create_toolbar) >>> > (xg_im_context_commit, xg_widget_style_updated) >>> > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_connect_data'. >>> > (xg_initialize): Remove linked list if HAVE_MPS. >>> > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper >>> > functions. >>> > * src/xmenu.c (menubar_selection_callback) >>> > (popup_selection_callback): Adjust to use `get_glib_user_data'. >>> >>> Hello, >>> >>> as on my system gsignal.h does not define G_CONNECT_DEFAULT but only >>> G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the >>> following on my system: >> >> Thank you! Can you let me know which gtk/glib version that is? I'd >> like to check the source code to make sure we can pass the right >> flag instead. >> >> I think we're okay just passing 0 instead. >> >> Pip > > Should be GTK 3.24.33 and glib 2.0. Passing 0 is correct.