From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Willcock Newsgroups: gmane.emacs.devel Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Date: Fri, 20 Sep 2024 20:39:47 +0100 Message-ID: <87zfo22jy4.fsf@ice9.digital> References: <87cyky43fb.fsf@ice9.digital> <86setu5f85.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18876"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Tassilo Horn , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 20 21:40:29 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1srjUS-0004eG-Uk for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Sep 2024 21:40:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srjTy-000298-6q; Fri, 20 Sep 2024 15:39:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srjTw-00028Z-J7 for emacs-devel@gnu.org; Fri, 20 Sep 2024 15:39:56 -0400 Original-Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srjTu-0006H8-Mt; Fri, 20 Sep 2024 15:39:56 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 7E3C5E0004; Fri, 20 Sep 2024 19:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1726861188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/4URf4odYJMRXbT30p64rVXEgBTcXvqQD+7yVFKfPGY=; b=HvgIM94P0Ebx6sgibzToscxS33XXzAU4YzjKwlU9iVU8CbWsjxAlpuRXVQBp0f83dOD/Qg ks2xbccXA5KDm07HqYou/4hjzSs8OEWtOnu7gBjMPj8DxofC/mfDsoBP2xjIyVpEqRb2Lh Ay1qe6++hHrOM2A4l6RIyq5P0m8r6wjwlv+IE0ElIKCR4dAP7FuKVRazq+EU+WhaJzHnde RUl9QX9VRlJWEp4PTIxnBEGIc1LDQg1tMGZLZo8y/k8iS/XmMkBaqHUNshHb0wLeAibEuH ReQNevYe3u/xjBdg1nh7hFbKXSG6P4Hi/zJC74/M2kKF2fo0GkPqEfe/yAoPnA== In-Reply-To: <86setu5f85.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Sep 2024 21:53:30 +0300") X-GND-Sasl: morgan@ice9.digital Received-SPF: pass client-ip=2001:4b98:dc4:8::224; envelope-from=morgan@ice9.digital; helo=relay4-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323865 Archived-At: Eli Zaretskii writes: >> Eventually I found the variable doc-view-mupdf-use-svg, and setting it >> to nil reverted the rendering to the old method where the text was >> visible. > > Why is that? If your system supports display of SVG images, why > wasn't the text readable? Tassilo, any ideas? I think it is rendering the text and the background of the document in the same colour. >> I suggest that, at the very least, this variable should be added to the >> NEWS file so that someone having rendering issues after upgrading can >> find it more easily. > > Thanks, I added it. Thanks! >> I am also not sure that having it default to t (enabling SVG rendering >> by default) is a good idea. It probably works well for certain types of >> document but it wasn't usable for the ones which I was viewing (which >> were all automated invoices sent by e-mail from multiple organisations). > > It is only non-nil if your Emacs supports display of SVG images, and > in that case I don't see why not do it. I think we should investigate > your problem in more detail to understand why it didn't work for you. > I hope Tassilo will have some ideas for looking into this. If the problem is down to the default colours not working with particular documents, then I imagine it will depend on how the PDF files are being styled. The documents that I couldn't read included invoices from Microsoft Azure, so potentially a lot of people could find the same issue. -- Morgan Willcock