From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: `vc-revert' keybinding Date: Tue, 05 Nov 2024 09:10:19 +0100 Message-ID: <87zfme9k44.fsf@ledu-giraud.fr> References: <87r07r3pef.fsf@ledu-giraud.fr> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9903"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: "Alfred M. Szmidt" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 05 09:11:14 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t8Eeg-0002RU-Jc for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Nov 2024 09:11:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8Edv-0005lq-Ug; Tue, 05 Nov 2024 03:10:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8Edu-0005ld-Cj for emacs-devel@gnu.org; Tue, 05 Nov 2024 03:10:26 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8Eds-0003qy-Fx; Tue, 05 Nov 2024 03:10:26 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=ZKL5cRtU Ih+ORIV6gaiDPFv+dCC5sIU/P4pM97EsvK4=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=UBFx9ifprkDfiqVnd3ZSYgEoWIV9r0 7wg3W4VlVmvA2gltPiG9LjsNzRpCxXucFBTn35VKpJOop+JrwcWMaUCw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=ZKL5cRtUIh+ORIV6 gaiDPFv+dCC5sIU/P4pM97EsvK4=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=kSbfUp9ZrYpGhWG8nkY2POzNsnjUxyfjowzcNj 7pU1mWBj/gzvC4O8YJHAS76q+CLKIlxmmvLi8Hl3KBAEyeuMG7a7zsl0u0C9R/t3UbF5gf 7DPHZ8cLosu4sdgoXrsc8j0b78Q9UpKm+hQzchtwAjImXgBWJ9y9ju/Nc/JUTotG4xmSLi LkVH7vjyB6t+x3+hwWzu9M7T1YZWmwF7dZV0S/wwQfQ7CQ98wDnQSvSH3Mqc97AxBwbV7b DvJE6ySE9VYvJSVxcn3/QX/qsUz0OIwvWr8xrz0GITrio7a4w2bXnROlcxAejpWgIpbmrK NkDWD7qdd73Ef4ShvJJyJeUQ== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 6e93c7da (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 5 Nov 2024 09:10:21 +0100 (CET) In-Reply-To: (Alfred M. Szmidt's message of "Mon, 04 Nov 2024 12:16:36 -0500") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325130 Archived-At: "Alfred M. Szmidt" writes: [...] > C-x u is undo, C-x v u makes a logical choice for "revert" (or undo > the file to the state it is in VC). Yes that make sense, of course. > Why is 'u' prevented from being "unmark" in vc dir? "Works for me"? I haven't made myself clear. As 'u' is already used for "unmark", it cannot be used as a VC dir shortcut for 'C-x v u' (vc-revert) without causing much confusion to the user. That is why I thought that we could have another character for this that would be the same for the 'C-x v' form, i.e.: - C-x v (globally) - (in VC dir mode) One can always use 'C-x v u' for both, but it seems strange that emacs does not have a VC dir shortcut for such a basic task. > Why not make it 'C-x v k' ("kill" these modifications) by default and > use 'k' as shortcut in VC Directory mode? Or maybe, keep 'C-x v u' and > add 'C-x v k' and 'k' in VC Directory mode? > > Kill would put something onto a kill ring, which would mean that one > should be able to "redo" something -- how that would work in VC is an > interesting question. Does it kill the commit? C-x v u reverts the > current file to whatever is in the repository (so .. undo?). Yes, you're right. -- Manuel Giraud