unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Manuel Giraud via "Emacs development discussions." <emacs-devel@gnu.org>
To: "Alfred M. Szmidt" <ams@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: `vc-revert' keybinding
Date: Tue, 05 Nov 2024 09:10:19 +0100	[thread overview]
Message-ID: <87zfme9k44.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <E1t80gu-0001c7-20@fencepost.gnu.org> (Alfred M. Szmidt's message of "Mon, 04 Nov 2024 12:16:36 -0500")

"Alfred M. Szmidt" <ams@gnu.org> writes:

[...]

> C-x u is undo, C-x v u makes a logical choice for "revert" (or undo
> the file to the state it is in VC).

Yes that make sense, of course.

> Why is 'u' prevented from being "unmark" in vc dir?  "Works for me"?

I haven't made myself clear.  As 'u' is already used for "unmark", it
cannot be used as a VC dir shortcut for 'C-x v u' (vc-revert) without
causing much confusion to the user.

That is why I thought that we could have another character for this that
would be the same for the 'C-x v' form, i.e.:

      - C-x v <somechar>  (globally)
      - <somechar>        (in VC dir mode)

One can always use 'C-x v u' for both, but it seems strange that emacs
does not have a VC dir shortcut for such a basic task.

>    Why not make it 'C-x v k' ("kill" these modifications) by default and
>    use 'k' as shortcut in VC Directory mode?  Or maybe, keep 'C-x v u' and
>    add 'C-x v k' and 'k' in VC Directory mode?
>
> Kill would put something onto a kill ring, which would mean that one
> should be able to "redo" something -- how that would work in VC is an
> interesting question.  Does it kill the commit?  C-x v u reverts the
> current file to whatever is in the repository (so .. undo?).

Yes, you're right.
-- 
Manuel Giraud



  reply	other threads:[~2024-11-05  8:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 17:00 `vc-revert' keybinding Manuel Giraud via Emacs development discussions.
2024-11-04 17:16 ` Alfred M. Szmidt
2024-11-05  8:10   ` Manuel Giraud via Emacs development discussions. [this message]
2024-11-05  8:56     ` Alfred M. Szmidt
2024-11-05 17:38       ` Juri Linkov
2024-11-05 17:44         ` Alfred M. Szmidt
2024-11-06  3:25           ` Sebastián Monía
2024-11-06  5:56             ` Alfred M. Szmidt
2024-11-06 10:24           ` Manuel Giraud via Emacs development discussions.
2024-11-05 17:39       ` chad
2024-11-06  9:42   ` Sean Whitton
2024-11-04 18:16 ` Sebastián Monía
2024-11-06  4:44 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfme9k44.fsf@ledu-giraud.fr \
    --to=emacs-devel@gnu.org \
    --cc=ams@gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).