From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Changes to emacs/lisp/progmodes/grep.el Date: Fri, 02 Jul 2004 12:07:46 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <87y8m2ydy5.fsf@mail.jurta.org> References: <87isdgnzzi.fsf@mail.jurta.org> <20040625220304.0f1fd05a@pfdabpc.inhouse.start.de> <20040627123340.5d3354cd@pfdabpc.inhouse.start.de> <20040628104013.5b4eb37e@pfdabpc.inhouse.start.de> <7494-Mon28Jun2004200058+0300-eliz@gnu.org> <20040628232216.5be7f8dd@pfdabpc.inhouse.start.de> <5567-Tue29Jun2004071049+0300-eliz@gnu.org> <20040629220851.07104e4c@pfdabpc.inhouse.start.de> <87oen1k4yc.fsf@mail.jurta.org> <20040702235848.255ecbbe@pfdabpc.inhouse.start.de> <20040703102837.146bd441@pfdabpc.inhouse.start.de> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1088759435 2849 80.91.224.253 (2 Jul 2004 09:10:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 2 Jul 2004 09:10:35 +0000 (UTC) Cc: Stefan , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Jul 02 11:10:24 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BgK3s-0002nN-00 for ; Fri, 02 Jul 2004 11:10:24 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BgK3s-0002ng-00 for ; Fri, 02 Jul 2004 11:10:24 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BgK5g-0005Y2-1O for emacs-devel@quimby.gnus.org; Fri, 02 Jul 2004 05:12:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BgK5c-0005Wn-LI for emacs-devel@gnu.org; Fri, 02 Jul 2004 05:12:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BgK5a-0005VL-3r for emacs-devel@gnu.org; Fri, 02 Jul 2004 05:12:11 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BgK5a-0005V2-2A for emacs-devel@gnu.org; Fri, 02 Jul 2004 05:12:10 -0400 Original-Received: from [66.33.219.6] (helo=knife.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BgK3h-0006Ms-6k for emacs-devel@gnu.org; Fri, 02 Jul 2004 05:10:13 -0400 Original-Received: from mail.jurta.org (80-235-32-26-dsl.mus.estpak.ee [80.235.32.26]) by knife.dreamhost.com (Postfix) with ESMTP id BA45EE4123; Fri, 2 Jul 2004 02:10:07 -0700 (PDT) Original-To: Daniel Pfeiffer In-Reply-To: <20040703102837.146bd441@pfdabpc.inhouse.start.de> (Daniel Pfeiffer's message of "Sat, 3 Jul 2004 10:28:37 +0200") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25388 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25388 dapfy@t-online.de (Daniel Pfeiffer) writes: > Stefan skribis: >> So using transient-mark-mode was just very natural and had the added >> advantage of being extremely easy to code. > > Juri's patch was no harder to code, if you look at how little he changed > there. My annoyance is that 0.5s is too short, so I would like to change the > semantics of compilation-highlight-regexp and the corresponding parameters to > be not t, but the duration. Or simply make it much longer, because it's > sit-for, so it goes away as soon as the user does something. Please look at http://lists.gnu.org/archive/html/emacs-devel/2004-06/msg00970.html Is it ok for you? > As for tmm, what shall we do? I feel that treating hits with column > information and without the same way, assuming first to last column in the > latter case is "clean". With an overlay it doesn't hurt at all. > > If we then however make it an option between overlay or tmm, that would mean > you'd get tmm for every compiler output line. Would you find this annoying? To be able to jump to the end of the region it is enough to simply set the mark at the other end, but activating the region for no reason is too annoying for users of transient-mark-mode since they should deactivate the mark by typing `C-g' after every match visit in the source buffer. So what is needed is to replace (push-mark end-mk nil t) with (push-mark end-mk) and use highlighted overlay in all cases. -- Juri Linkov http://www.jurta.org/emacs/