From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: Coding system conversion error Date: Sun, 13 Feb 2005 11:10:11 -0500 Message-ID: <87y8ds4f6d.fsf-monnier+emacs@gnu.org> References: <20050205170221.ZTBD24781.mxfep02.bredband.com@coolsville.localdomain> <738f9db09f1986269b8f5719d45d2dd5@swipnet.se> <4207DAF0.6000204@swipnet.se> <4209342E.5010701@swipnet.se> <165be0ad579be34852d18cc600114175@swipnet.se> <420BD292.6040607@swipnet.se> <200502120157.KAA24490@etlken.m17n.org> <30e47fd1ee5ebcc03c15fe8c905bc525@swipnet.se> <200502130014.JAA26774@etlken.m17n.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1108313096 5642 80.91.229.2 (13 Feb 2005 16:44:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 13 Feb 2005 16:44:56 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, "Jan D." , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 13 17:44:55 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D0MrS-0008I4-Tv for ged-emacs-devel@m.gmane.org; Sun, 13 Feb 2005 17:44:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D0N6o-00067j-Ka for ged-emacs-devel@m.gmane.org; Sun, 13 Feb 2005 12:00:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D0N57-0005wi-GX for emacs-devel@gnu.org; Sun, 13 Feb 2005 11:58:49 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D0N4s-0005st-W7 for emacs-devel@gnu.org; Sun, 13 Feb 2005 11:58:36 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D0N4s-0005oC-4F; Sun, 13 Feb 2005 11:58:34 -0500 Original-Received: from [209.226.175.193] (helo=tomts49-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D0MTM-0000Ff-KY; Sun, 13 Feb 2005 11:19:49 -0500 Original-Received: from alfajor ([65.92.240.235]) by tomts22-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050213161011.YKAS1919.tomts22-srv.bellnexxia.net@alfajor>; Sun, 13 Feb 2005 11:10:11 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 33C52D7315; Sun, 13 Feb 2005 11:10:11 -0500 (EST) Original-To: Kenichi Handa In-Reply-To: <200502130014.JAA26774@etlken.m17n.org> (Kenichi Handa's message of "Sun, 13 Feb 2005 09:14:01 +0900 (JST)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: main.gmane.org gmane.emacs.devel:33342 gmane.emacs.pretest.bugs:5856 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:33342 > I agree that signaling an error is better than xassert. > But, it seems that a function in selection-converter-alist > can return a multibyte string as long as we have a fixed > rule about how to handle it. And "converting to a unibyte > string by string-make-unibyte" seems to be a good rule. String-make-unibyte might not do the right thing. It's just a guess when we don't have any alternative. In this case we have an alternative which is to signal an error. After all, this did catch an error in the handling of encode-coding-string with compound-text, so I think it's better to signal the error than to silently try to correct it. Stefan