From: Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>
Subject: org-mode and mode hooks.
Date: Wed, 25 May 2005 15:31:07 +0200 [thread overview]
Message-ID: <87y8a3mnz8.fsf@xs4all.nl> (raw)
org-mode in lisp/textmodes/org.el is derived from outline-mode, but it
doesn't use define-derived-mode to accomplish this. Instead, it just
calls outline-mode as the first thing it does. (I guess this is
because org-mode accepts an argument, which define-derived-mode
doesn't support.) The problem with this approach is that
outline-mode's mode hook and after-change-major-mode-hook are run at
the wrong time. What about the following patch to fix this?
Lute.
Index: lisp/textmodes/org.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/textmodes/org.el,v
retrieving revision 1.18
diff -c -r1.18 org.el
*** lisp/textmodes/org.el 20 May 2005 11:24:48 -0000 1.18
--- lisp/textmodes/org.el 25 May 2005 13:27:59 -0000
***************
*** 1544,1550 ****
\\{org-mode-map}"
(interactive "P")
! (outline-mode)
(setq major-mode 'org-mode)
(setq mode-name "Org")
(use-local-map org-mode-map)
--- 1544,1551 ----
\\{org-mode-map}"
(interactive "P")
! (delay-mode-hooks
! (outline-mode))
(setq major-mode 'org-mode)
(setq mode-name "Org")
(use-local-map org-mode-map)
***************
*** 1577,1583 ****
(save-excursion
(goto-char (point-min))
(insert " -*- mode: org -*-\n\n")))
! (run-hooks 'org-mode-hook)
(unless org-inhibit-startup
(if org-startup-with-deadline-check
(call-interactively 'org-check-deadlines)
--- 1578,1584 ----
(save-excursion
(goto-char (point-min))
(insert " -*- mode: org -*-\n\n")))
! (run-mode-hooks 'org-mode-hook)
(unless org-inhibit-startup
(if org-startup-with-deadline-check
(call-interactively 'org-check-deadlines)
***************
*** 3120,3126 ****
"--")
(mapcar 'org-file-menu-entry org-agenda-files)))
(org-agenda-set-mode-name)
! (run-hooks 'org-agenda-mode-hook))
(define-key org-agenda-mode-map [(tab)] 'org-agenda-goto)
(define-key org-agenda-mode-map [(return)] 'org-agenda-switch-to)
--- 3121,3127 ----
"--")
(mapcar 'org-file-menu-entry org-agenda-files)))
(org-agenda-set-mode-name)
! (run-mode-hooks 'org-agenda-mode-hook))
(define-key org-agenda-mode-map [(tab)] 'org-agenda-goto)
(define-key org-agenda-mode-map [(return)] 'org-agenda-switch-to)
next reply other threads:[~2005-05-25 13:31 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-25 13:31 Lute Kamstra [this message]
2005-05-25 14:45 ` org-mode and mode hooks Stefan Monnier
2005-05-25 15:20 ` Carsten Dominik
2005-05-25 15:44 ` Lute Kamstra
2005-05-25 16:36 ` Luc Teirlinck
2005-05-25 17:01 ` Lute Kamstra
2005-05-25 17:12 ` Luc Teirlinck
2005-05-25 17:28 ` Lute Kamstra
2005-05-25 17:45 ` Luc Teirlinck
2005-05-25 16:24 ` Luc Teirlinck
2005-05-26 6:00 ` Richard Stallman
2005-05-26 10:31 ` Lute Kamstra
2005-05-26 17:31 ` Lute Kamstra
2005-05-27 14:18 ` Richard Stallman
2005-06-27 8:25 ` Lute Kamstra
2005-06-28 4:16 ` Richard M. Stallman
2005-05-27 3:39 ` Richard Stallman
2005-05-27 8:07 ` Juri Linkov
2005-06-27 8:28 ` Lute Kamstra
2005-05-25 17:30 ` Luc Teirlinck
2005-05-25 21:35 ` Luc Teirlinck
2005-05-25 22:15 ` Stefan Monnier
2005-05-26 3:59 ` Luc Teirlinck
2005-05-26 14:08 ` Stefan Monnier
2005-05-26 15:01 ` Luc Teirlinck
2005-05-26 17:04 ` Stefan Monnier
2005-05-27 17:17 ` Luc Teirlinck
2005-05-27 17:27 ` Luc Teirlinck
2005-05-28 11:53 ` Richard Stallman
2005-05-29 1:57 ` Luc Teirlinck
2005-05-29 12:04 ` Richard Stallman
2005-05-29 23:54 ` Luc Teirlinck
2005-05-31 4:18 ` Richard Stallman
2005-05-31 15:44 ` Luc Teirlinck
2005-05-31 19:08 ` Stefan Monnier
2005-06-01 3:50 ` Luc Teirlinck
2005-06-01 17:22 ` Richard Stallman
2005-06-01 19:11 ` Luc Teirlinck
2005-06-01 21:21 ` Stefan Monnier
2005-06-01 22:42 ` Luc Teirlinck
2005-06-01 22:55 ` Stefan Monnier
2005-06-01 23:26 ` Luc Teirlinck
2005-06-01 23:43 ` Stefan Monnier
2005-06-01 23:55 ` Luc Teirlinck
2005-06-01 23:57 ` Luc Teirlinck
2005-06-01 23:58 ` David Kastrup
2005-06-02 0:15 ` Luc Teirlinck
2005-06-01 23:49 ` Luc Teirlinck
2005-06-03 8:01 ` Richard Stallman
2005-06-03 14:59 ` Luc Teirlinck
2005-06-03 15:05 ` Luc Teirlinck
2005-06-04 10:16 ` Richard Stallman
2005-06-04 14:54 ` Luc Teirlinck
2005-06-04 16:33 ` Stefan Monnier
2005-06-04 17:48 ` Luc Teirlinck
2005-06-05 0:36 ` David Kastrup
2005-06-05 9:47 ` Richard Stallman
2005-06-07 0:23 ` Luc Teirlinck
2005-06-04 15:17 ` Luc Teirlinck
2005-06-05 9:47 ` Richard Stallman
2005-06-06 23:28 ` Luc Teirlinck
2005-06-07 18:15 ` Stefan Monnier
2005-06-07 19:08 ` Luc Teirlinck
2005-06-07 22:10 ` Stefan Monnier
2005-06-08 1:36 ` Luc Teirlinck
2005-06-08 16:15 ` Stefan Monnier
2005-06-09 1:06 ` Luc Teirlinck
2005-06-08 12:02 ` Richard Stallman
2005-06-02 6:15 ` Carsten Dominik
2005-06-01 19:14 ` Luc Teirlinck
2005-06-01 19:19 ` Luc Teirlinck
2005-06-01 21:24 ` Stefan Monnier
2005-05-31 16:30 ` Luc Teirlinck
2005-06-01 2:33 ` Luc Teirlinck
2005-06-01 17:23 ` Richard Stallman
2005-06-01 17:48 ` Luc Teirlinck
2005-06-01 2:42 ` Luc Teirlinck
2005-06-01 17:23 ` Richard Stallman
2005-06-01 18:05 ` Luc Teirlinck
2005-06-01 2:47 ` Luc Teirlinck
2005-06-01 17:23 ` Richard Stallman
2005-06-02 3:21 ` Luc Teirlinck
2005-06-03 22:32 ` Richard Stallman
2005-06-03 23:08 ` Luc Teirlinck
2005-06-04 18:00 ` Richard Stallman
2005-06-01 3:01 ` Luc Teirlinck
2005-05-30 1:43 ` Luc Teirlinck
2005-05-30 2:50 ` Luc Teirlinck
2005-05-30 15:31 ` Luc Teirlinck
2005-05-30 16:52 ` Luc Teirlinck
2005-05-30 17:24 ` Luc Teirlinck
2005-05-30 3:35 ` Luc Teirlinck
2005-05-29 2:20 ` Luc Teirlinck
2005-05-29 12:04 ` Richard Stallman
2005-05-30 0:42 ` Luc Teirlinck
2005-05-30 1:58 ` Luc Teirlinck
2005-05-28 1:58 ` Luc Teirlinck
2005-05-27 14:49 ` Michael Mauger
2005-05-27 15:35 ` Luc Teirlinck
2005-05-27 16:40 ` Luc Teirlinck
2005-05-27 17:15 ` Stefan Monnier
2005-05-27 19:13 ` Luc Teirlinck
2005-05-31 18:25 ` Michael Mauger
2005-05-27 19:43 ` Luc Teirlinck
2005-05-28 11:53 ` Richard Stallman
2005-05-28 18:48 ` Luc Teirlinck
2005-06-07 1:19 ` Luc Teirlinck
2005-06-07 1:49 ` Miles Bader
2005-06-07 1:55 ` Luc Teirlinck
2005-06-07 2:01 ` Miles Bader
2005-06-07 18:23 ` Stefan Monnier
2005-06-07 18:17 ` Stefan Monnier
2005-06-08 12:01 ` Richard Stallman
2005-05-26 14:53 ` Richard Stallman
2005-05-26 15:06 ` Luc Teirlinck
2005-05-26 4:16 ` Luc Teirlinck
2005-05-25 22:22 ` Lute Kamstra
[not found] ` <17044.33688.784219.190965@sam.science.uva.nl>
2005-05-25 15:37 ` Lute Kamstra
2005-05-25 15:49 ` Carsten Dominik
2005-05-26 5:59 ` Richard Stallman
[not found] <87sm07o3oz.fsf-monnier+emacs@gnu.org>
2005-05-29 2:00 ` Luc Teirlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y8a3mnz8.fsf@xs4all.nl \
--to=lute.kamstra.lists@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).