From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: mouse-1-click-follows-link and mime messages Date: Wed, 08 Feb 2006 15:51:19 -0500 Message-ID: <87y80lo9q0.fsf@stupidchicken.com> References: <87acd48bhi.fsf@stupidchicken.com> <87acd3mx3u.fsf@pacem.orebokech.com> <877j86929j.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1139440727 31571 80.91.229.2 (8 Feb 2006 23:18:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 8 Feb 2006 23:18:47 +0000 (UTC) Cc: romain@orebokech.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 09 00:18:43 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F6ya9-0001lC-5h for ged-emacs-devel@m.gmane.org; Thu, 09 Feb 2006 00:18:41 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F6ya8-0000Y0-Gd for ged-emacs-devel@m.gmane.org; Wed, 08 Feb 2006 18:18:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F6wGQ-0006Jp-Ll for emacs-devel@gnu.org; Wed, 08 Feb 2006 15:50:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F6wGJ-0006Fq-BJ for emacs-devel@gnu.org; Wed, 08 Feb 2006 15:50:07 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F6wGI-0006FQ-8u for emacs-devel@gnu.org; Wed, 08 Feb 2006 15:50:02 -0500 Original-Received: from [18.19.6.82] (helo=localhost.localdomain) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F6wJT-0001ht-IO; Wed, 08 Feb 2006 15:53:19 -0500 Original-Received: by localhost.localdomain (Postfix, from userid 1000) id EE43E12089B; Wed, 8 Feb 2006 15:51:19 -0500 (EST) Original-To: rms@gnu.org In-Reply-To: (Richard M. Stallman's message of "Wed, 08 Feb 2006 14:05:02 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50222 Archived-At: "Richard M. Stallman" writes: > > * mouse.el (mouse-drag-region-1): When remapping mouse-1 to > > mouse-2, go back to previously selected window, so it's selected > > when mouse-2 command runs. > > Looks like this affects all `link' widgets. For instance, clicking on > the links in the Customize buffer does not work if another window is > selected. > > The change I made is correct in principle. When the mouse-2 command > finally gets run, the selected window should not have been altered by > the translation mechanism. The event says which window was clicked > on. The selected window should be the one that was selected by the > user. > > It sounds like the command that handles mouse-2 on a link needs fixing. I figured out the problem. We should only change the selected window if we are translating to mouse-2. The `follow-link' property can also specify translation to, e.g., "\C-m" (in the case of the link widget); in that case, we shouldn't change the window. I've checked in a fix.