From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Bug in incremental undrawing of mouseover highlighting Date: Sat, 25 Nov 2006 11:18:14 -0500 Message-ID: <87y7pzo5yx.fsf@stupidchicken.com> References: <17760.56196.739515.442009@rgrjr.dyndns.org> <87zmaludmg.fsf@cyd.mit.edu> <87hcwokvkk.fsf@furball.mit.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1164471500 24231 80.91.229.2 (25 Nov 2006 16:18:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 25 Nov 2006 16:18:20 +0000 (UTC) Cc: rogers-emacs@rgrjr.dyndns.org, YAMAMOTO Mitsuharu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 25 17:18:15 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Go0EJ-0001Mr-B5 for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2006 17:18:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Go0EI-00028c-QQ for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2006 11:18:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Go0E7-00028I-VZ for emacs-devel@gnu.org; Sat, 25 Nov 2006 11:18:04 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Go0E6-00027l-GG for emacs-devel@gnu.org; Sat, 25 Nov 2006 11:18:03 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Go0E6-00027g-31 for emacs-devel@gnu.org; Sat, 25 Nov 2006 11:18:02 -0500 Original-Received: from [18.19.1.138] (helo=cyd.mit.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Go0E4-0001W4-7G; Sat, 25 Nov 2006 11:18:00 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 801664E3F7; Sat, 25 Nov 2006 11:18:14 -0500 (EST) Original-To: Eli Zaretskii In-Reply-To: (Eli Zaretskii's message of "Sat\, 25 Nov 2006 12\:53\:11 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.91 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62800 Archived-At: >> Also, I think this is a bad timing to commit such a change for a >> non-critical bug without approval by some expert. If anyone has a suggestion for a cleaner non-invasive change, it would be welcome. I'm also agreeable to postphoning this bugfix till after the release, if it is considered unsafe. > I don't consider myself much of a redisplay expert, but I did express > a (different) concern for the patch as posted, a concern that > seemingly had no effect whatsoever. It's still unclear, from the messages you sent, whether this bug can happen outside of HAVE_WINDOW_SYSTEM. The bugfix is meant to plug a loophole in the code in note_mouse_highlight that computes whether or not the mouse highlight has been updated, which is only present for HAVE_WINDOW_SYSTEM. (It is possible to change note_mouse_highlight itself, e.g. by introducing dpyinfo->mouse_face_buffer. This turns out, however, to be a fairly intricate change.)