* uncache_image weirdness
@ 2007-05-25 0:36 Miles Bader
2007-05-25 2:02 ` Chong Yidong
0 siblings, 1 reply; 2+ messages in thread
From: Miles Bader @ 2007-05-25 0:36 UTC (permalink / raw)
To: Chong Yidong; +Cc: emacs-devel
In the new function you wrote, "uncache_image", I don't understand why you
call lookup_image (the return value isn't even used). Wouldn't it work to
just search the table and free any matching spec, _without_ calling
lookup_image? In the case of an image that isn't actually in the cache, it
seems silly to load the image just to immediately free it...
Thanks,
-Miles
--
`Cars give people wonderful freedom and increase their opportunities.
But they also destroy the environment, to an extent so drastic that
they kill all social life' (from _A Pattern Language_)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: uncache_image weirdness
2007-05-25 0:36 uncache_image weirdness Miles Bader
@ 2007-05-25 2:02 ` Chong Yidong
0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2007-05-25 2:02 UTC (permalink / raw)
To: Miles Bader; +Cc: emacs-devel
Miles Bader <miles@gnu.org> writes:
> In the new function you wrote, "uncache_image", I don't understand why you
> call lookup_image (the return value isn't even used). Wouldn't it work to
> just search the table and free any matching spec, _without_ calling
> lookup_image? In the case of an image that isn't actually in the cache, it
> seems silly to load the image just to immediately free it...
That was a typo. Thanks for spotting it.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-25 2:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-25 0:36 uncache_image weirdness Miles Bader
2007-05-25 2:02 ` Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).