bug with speedbar

bug with speedbar

[Thierry Volpiatto]

Hello, i have submit a bug to bugzilla(gentoo) and they told me to send
it to you.

speedbar don't work in >=emacs-cvs-22 
It seem the variable dframe-xemacsp is not used anymore in dframe.el
so i set in my .emacs:
(setq dframe-xemacsp nil)
and it's work fine like that, it solved for me.

may be you can add that in speedbar.el or in dframe.el, or else where, i
don't know.

-- 
A +
Thierry
PS:You can find my pubkey here:
http://pgp.mit.edu/

Re: bug with speedbar

[Ulrich Mueller]

>>>>> On Thu, 30 Aug 2007, Thierry Volpiatto wrote:

> speedbar don't work in >=emacs-cvs-22 
> It seem the variable dframe-xemacsp is not used anymore in dframe.el

This affects both the trunk and EMACS_22_BASE. The following patch
should fix it:

2007-08-31  Ulrich Mueller  <ulm@gentoo.org>

	* speedbar.el (speedbar-check-vc, speedbar-frame-mode) 
	(speedbar-frame-reposition-smartly, speedbar-reconfigure-keymaps) 
	(speedbar-set-mode-line-format): Remove references to variable
	`dframe-xemacsp'.

--- lisp/speedbar.el.~1.89.~	2007-07-28 02:23:30.000000000 +0200
+++ lisp/speedbar.el	2007-08-31 08:23:34.000000000 +0200
@@ -994,7 +994,7 @@
 		     'speedbar-buffer
 		     "Speedbar"
 		     #'speedbar-frame-mode
-		     (if dframe-xemacsp
+		     (if (featurep 'xemacs)
 			 (append speedbar-frame-plist
 				 ;; This is a hack to get speedbar to iconfiy
 				 ;; with the selected frame.
@@ -1020,7 +1020,7 @@
 
 (defun speedbar-frame-reposition-smartly ()
   "Reposition the speedbar frame to be next to the attached frame."
-  (cond ((and dframe-xemacsp
+  (cond ((and (featurep 'xemacs)
 	      (or (member 'left speedbar-frame-plist)
 		  (member 'top speedbar-frame-plist)))
 	 (dframe-reposition-frame
@@ -1029,7 +1029,7 @@
 	  (cons (car (cdr (member 'left speedbar-frame-plist)))
 		(car (cdr (member 'top speedbar-frame-plist)))))
 	 )
-	((and (not dframe-xemacsp)
+	((and (not (featurep 'xemacs))
 	      (or (assoc 'left speedbar-frame-parameters)
 		  (assoc 'top speedbar-frame-parameters)))
 	 ;; if left/top were specified in the parameters, pass them
@@ -1164,7 +1164,7 @@
 This gives visual indications of what is up.  It EXPECTS the speedbar
 frame and window to be the currently active frame and window."
   (if (and (frame-live-p (speedbar-current-frame))
-	   (or (not dframe-xemacsp)
+	   (or (not (featurep 'xemacs))
 	       (with-no-warnings
 		 (specifier-instance has-modeline-p)))
 	   speedbar-buffer)
@@ -1252,7 +1252,7 @@
       (if speedbar-previous-menu (easy-menu-remove speedbar-previous-menu))
       (setq speedbar-previous-menu md)
       ;; Now add the new menu
-      (if (not dframe-xemacsp)
+      (if (not (featurep 'xemacs))
 	  (easy-menu-define speedbar-menu-map (current-local-map)
 			    "Speedbar menu" md)
 	(easy-menu-add md (current-local-map))
@@ -2915,7 +2915,7 @@
 	     (not (or (and (featurep 'ange-ftp)
 			   (string-match
 			    (car (symbol-value
-				  (if dframe-xemacsp
+				  (if (featurep 'xemacs)
 				      'ange-ftp-directory-format
 				    'ange-ftp-name-format)))
 			    (expand-file-name default-directory)))

Re: bug with speedbar

[Richard Stallman]

I fixed that in Emacs 22.  It will get merged into the trunk.