From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Ruby mode added Date: Wed, 10 Dec 2008 14:08:59 -0500 Message-ID: <87y6yn26gk.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228936269 8216 80.91.229.12 (10 Dec 2008 19:11:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2008 19:11:09 +0000 (UTC) Cc: Phil Hagelberg To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 10 20:12:13 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LAUTN-00087z-Jj for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2008 20:11:49 +0100 Original-Received: from localhost ([127.0.0.1]:42174 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAUSC-0001Jo-Au for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2008 14:10:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAUQb-0000QU-9y for emacs-devel@gnu.org; Wed, 10 Dec 2008 14:08:57 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAUQZ-0000Oz-8q for emacs-devel@gnu.org; Wed, 10 Dec 2008 14:08:56 -0500 Original-Received: from [199.232.76.173] (port=59814 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAUQY-0000Ou-QL for emacs-devel@gnu.org; Wed, 10 Dec 2008 14:08:54 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:37850) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LAUQY-0002YN-Fj for emacs-devel@gnu.org; Wed, 10 Dec 2008 14:08:54 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 56D0457E1C8; Wed, 10 Dec 2008 14:08:59 -0500 (EST) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106769 Archived-At: Richard has okayed adding Ruby-mode to CVS, and I've done so. I made a few changes with respect to Phil Hagelberg's version at github: - Moved definition of ruby-mode to the end of the file to avoid compiler warnings. - Removed the defun-region-command macro. Is there a better way for this file to remain XEmacs-compatible without this hack? (eval-when-compile (defmacro defun-region-command (func args &rest body) (let ((intr (car body))) (when (featurep 'xemacs) (if (stringp intr) (setq intr (cadr body))) (and (eq (car intr) 'interactive) (setq intr (cdr intr)) (setcar intr (concat "_" (car intr))))) (cons 'defun (cons func (cons args body)))))) - There seemed to be a reference to an unbound variable, `indent-point', in ruby-parse-partial. I assumed this was an attempt to use dynamic scope to access the let-bound variable `indent-point' in ruby-calculate-indent; therefore I renamed indent-point as ruby-indent-point and added a `boundp' check. Phil, could you check if this is the intention of the code? I have also updated NEWS and the Emacs manual. Does anyone see any problem?