From: Ivan Kanis <expire-by-2009-09-17@kanis.fr>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Per Bothner <per@bothner.com>, Dan Nicolaescu <dann@ics.uci.edu>,
emacs-devel@gnu.org
Subject: Re: PATCH term optional bold
Date: Sat, 12 Sep 2009 09:32:13 +0200 [thread overview]
Message-ID: <87y6ok62ki.fsf@kanis.fr> (raw)
In-Reply-To: <jwvsketjrxm.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 11 Sep 2009 13:48:31 -0400")
Hi Stefan,
Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> This small patch make optional the usage of bold attribute in term.
> Could you give us some background explaining the motivation for this?
I can't stand bold font and try to disable it whenever I can. There is a
big misunderstanding about bold in terminal emulation. In a true dumb
terminal like a vt220 bold was a brighter color.
> I think it'd be even better to do something like
> [...your patch..]
>> (when term-ansi-current-bold
>> (setq term-current-face
>> - (append '(:weight bold) term-current-face)))
>> + (append term-bold-attribute term-current-face)))
>
> WDYT?
I think it's better it allows more customization, I have fixed up your
patch a little bit and tested. I use progn for the setq and update the
comment of the defvar.
--- a/lisp/misc/term.el Fri Sep 11 14:36:54 2009 +0200
+++ b/lisp/misc/term.el Sat Sep 12 09:29:30 2009 +0200
@@ -476,11 +476,16 @@
(defvar term-old-mode-line-format) ;; Saves old mode-line-format while paging.
(defvar term-pager-old-local-map nil) ;; Saves old keymap while paging.
(defvar term-pager-old-filter) ;; Saved process-filter while paging.
(defcustom explicit-shell-file-name nil
"If non-nil, is file name to use for explicitly requested inferior shell."
:type '(choice (const nil) file)
:group 'term)
+
+(defvar term-enable-bold t
+ "Set to nil to disable bold")
+
+(defvar term-bold-attribute '(:weight bold)
+ "Set to '(:weight normal) to disable bold")
(defvar term-prompt-regexp "^"
"Regexp to recognize prompts in the inferior process.
@@ -3228,8 +3233,9 @@
term-default-bg-color
(elt ansi-term-color-vector term-ansi-current-bg-color
))))
(when term-ansi-current-bold
- (setq term-current-face
- (append '(:weight bold) term-current-face)))
+ (setq term-current-face
+ (append '(:weight bold) term-current-face)
+ (append term-bold-attribute term-current-face)))
(when term-ansi-current-underline
(setq term-current-face
(append '(:underline t) term-current-face))))
@@ -3257,7 +3263,9 @@
(elt ansi-term-color-vector term-ansi-current-bg-color))
))
(when term-ansi-current-bold
(setq term-current-face
- (append '(:weight bold) term-current-face)))
+ (progn
+ (append '(:weight bold) term-current-face)
+ (append '(:weight bold) term-current-face)))
(when term-ansi-current-underline
(setq term-current-face
(append '(:underline t) term-current-face))))))
next prev parent reply other threads:[~2009-09-12 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 13:36 PATCH term optional bold Ivan Kanis
2009-09-11 17:48 ` Stefan Monnier
2009-09-12 7:32 ` Ivan Kanis [this message]
2009-09-12 13:56 ` Miles Bader
2009-09-12 16:35 ` Ivan Kanis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6ok62ki.fsf@kanis.fr \
--to=expire-by-2009-09-17@kanis.fr \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=per@bothner.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).