From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: pointless buttons at end of VC log buffers Date: Thu, 18 Feb 2010 07:36:45 +0900 Message-ID: <87y6ir5w1u.fsf@catnip.gol.com> References: <87pr45zqn3.fsf@telefonica.net> <87ljetz5ha.fsf@telefonica.net> <87wrydb80p.fsf@catnip.gol.com> Reply-To: Miles Bader NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1266446232 20474 80.91.229.12 (17 Feb 2010 22:37:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Feb 2010 22:37:12 +0000 (UTC) Cc: =?utf-8?Q?=C3=93scar?= Fuentes , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 17 23:37:00 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NhsVu-0000gP-GG for ged-emacs-devel@m.gmane.org; Wed, 17 Feb 2010 23:36:58 +0100 Original-Received: from localhost ([127.0.0.1]:48798 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhsVt-0006VZ-Su for ged-emacs-devel@m.gmane.org; Wed, 17 Feb 2010 17:36:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhsVo-0006UR-Nf for emacs-devel@gnu.org; Wed, 17 Feb 2010 17:36:52 -0500 Original-Received: from [140.186.70.92] (port=59068 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhsVo-0006TW-0s for emacs-devel@gnu.org; Wed, 17 Feb 2010 17:36:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NhsVl-0004A5-E0 for emacs-devel@gnu.org; Wed, 17 Feb 2010 17:36:51 -0500 Original-Received: from smtp11.dentaku.gol.com ([203.216.5.73]:33804) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NhsVl-00049s-5O; Wed, 17 Feb 2010 17:36:49 -0500 Original-Received: from 218.231.149.163.eo.eaccess.ne.jp ([218.231.149.163] helo=catnip.gol.com) by smtp11.dentaku.gol.com with esmtpa (Dentaku) id 1NhsVi-0001q4-8u; Thu, 18 Feb 2010 07:36:46 +0900 Original-Received: by catnip.gol.com (Postfix, from userid 1000) id B3E97DF74; Thu, 18 Feb 2010 07:36:45 +0900 (JST) System-Type: x86_64-unknown-linux-gnu In-Reply-To: (Stefan Monnier's message of "Tue, 16 Feb 2010 11:49:49 -0500") Original-Lines: 26 X-Virus-Scanned: ClamAV GOL (outbound) X-Abuse-Complaints: abuse@gol.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121170 Archived-At: BTW, the following patch should add the missing newline for git (a further blank line added in the generic part would also make things prettier): diff --git a/lisp/vc-git.el b/lisp/vc-git.el index 0d8e630..ad99e2e 100644 --- a/lisp/vc-git.el +++ b/lisp/vc-git.el @@ -551,7 +551,7 @@ If nil, use the value of `vc-diff-switches'. If t, use no switches." '("log" "--no-color") (when shortlog '("--graph" "--decorate" - "--date=short" "--pretty=format:%d%h %ad %s" "--abbrev-commit")) + "--date=short" "--pretty=tformat:%d%h %ad %s" "--abbrev-commit")) (when limit (list "-n" (format "%s" limit))) (when start-revision (list start-revision)) '("--"))))))) Thanks, -Miles -- One of the lessons of history is that nothing is often a good thing to do, and always a clever thing to say. -- Will Durant