unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Miles Bader <miles@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: "Óscar Fuentes" <ofv@wanadoo.es>, emacs-devel@gnu.org
Subject: Re: pointless buttons at end of VC log buffers
Date: Thu, 18 Feb 2010 07:36:45 +0900	[thread overview]
Message-ID: <87y6ir5w1u.fsf@catnip.gol.com> (raw)
In-Reply-To: <jwvvddxf7or.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 16 Feb 2010 11:49:49 -0500")

BTW, the following patch should add the missing newline for git (a
further blank line added in the generic part would also make things prettier):


diff --git a/lisp/vc-git.el b/lisp/vc-git.el
index 0d8e630..ad99e2e 100644
--- a/lisp/vc-git.el
+++ b/lisp/vc-git.el
@@ -551,7 +551,7 @@ If nil, use the value of `vc-diff-switches'.  If t, use no switches."
 		'("log" "--no-color")
 		(when shortlog
 		  '("--graph" "--decorate"
-		    "--date=short" "--pretty=format:%d%h  %ad  %s" "--abbrev-commit"))
+		    "--date=short" "--pretty=tformat:%d%h  %ad  %s" "--abbrev-commit"))
 		(when limit (list "-n" (format "%s" limit)))
 		(when start-revision (list start-revision))
 		'("--")))))))


Thanks,

-Miles

-- 
One of the lessons of history is that nothing is often a good thing to
do, and always a clever thing to say.  -- Will Durant




      reply	other threads:[~2010-02-17 22:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16  4:42 pointless buttons at end of VC log buffers Miles Bader
2010-02-16  5:38 ` Óscar Fuentes
2010-02-16  8:43   ` Miles Bader
2010-02-16 13:15     ` Óscar Fuentes
2010-02-16 13:54       ` Miles Bader
2010-02-16 16:49         ` Stefan Monnier
2010-02-17 22:36           ` Miles Bader [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6ir5w1u.fsf@catnip.gol.com \
    --to=miles@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=ofv@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).