From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: emacs-21.1.94 crash in gnus on Windows Date: Thu, 25 Mar 2010 12:35:05 -0400 Message-ID: <87y6hg5phi.fsf@stupidchicken.com> References: <84634x887o.fsf@gmail.com> <4B9F7F5F.1040504@gmail.com> <84eijkm21x.fsf@gmail.com> <87tys5be09.fsf@stupidchicken.com> <83fx3pghrq.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1269537030 15822 80.91.229.12 (25 Mar 2010 17:10:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 25 Mar 2010 17:10:30 +0000 (UTC) Cc: andrewjmoreton@gmail.com, schwab@linux-m68k.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 25 18:10:25 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NuqZc-0003bb-5a for ged-emacs-devel@m.gmane.org; Thu, 25 Mar 2010 18:10:24 +0100 Original-Received: from localhost ([127.0.0.1]:44290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuqZb-000766-6J for ged-emacs-devel@m.gmane.org; Thu, 25 Mar 2010 13:10:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nuq1a-0002LU-U4 for emacs-devel@gnu.org; Thu, 25 Mar 2010 12:35:15 -0400 Original-Received: from [140.186.70.92] (port=49328 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nuq1X-0002Is-BV for emacs-devel@gnu.org; Thu, 25 Mar 2010 12:35:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nuq1U-0003dm-Lr for emacs-devel@gnu.org; Thu, 25 Mar 2010 12:35:11 -0400 Original-Received: from pantheon-po35.its.yale.edu ([130.132.50.83]:46852) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nuq1U-0003de-Iz; Thu, 25 Mar 2010 12:35:08 -0400 Original-Received: from furry (dhcp128036014175.central.yale.edu [128.36.14.175]) (authenticated bits=0) by pantheon-po35.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o2PGZ56m025174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 25 Mar 2010 12:35:05 -0400 Original-Received: by furry (Postfix, from userid 1000) id 405EBC011; Thu, 25 Mar 2010 12:35:05 -0400 (EDT) In-Reply-To: <83fx3pghrq.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Mar 2010 06:14:01 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.94 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122662 Archived-At: Eli Zaretskii writes: > But the part that you left in the code also uses it.glyph_row, which > is garbage after a call to move_it_to. There's a single use of > it.glyph_row->x before the call to PRODUCE_GLYPHS (&it2), and I think > that needs to be fixed as well, because it potentially dereferences a > bad pointer. > > Or did I miss something? I don't see the failure condition. This branch handles the special case of charpos == 1 or charpos above the top of the window. Since start_display initialized the iterator using the desired matrix of the window, it.glyph_row should always be valid. Or am I confused?