From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99831: Scrolling commands which does not signal errors at top/bottom. Date: Wed, 14 Apr 2010 19:49:10 +0300 Organization: JURTA Message-ID: <87y6gq6la3.fsf@mail.jurta.org> References: <877hol5qso.fsf@mail.jurta.org> <874ojozp27.fsf@mail.jurta.org> <87ljd0wcw3.fsf@mail.jurta.org> <876344wamo.fsf@mail.jurta.org> <874ojn8eqf.fsf@mail.jurta.org> <87aatcnufw.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1271264339 13321 80.91.229.12 (14 Apr 2010 16:58:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 14 Apr 2010 16:58:59 +0000 (UTC) Cc: Juanma Barranquero , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 14 18:58:58 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O25vU-0007yT-Ey for ged-emacs-devel@m.gmane.org; Wed, 14 Apr 2010 18:58:56 +0200 Original-Received: from localhost ([127.0.0.1]:54123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O25vU-0002CW-1G for ged-emacs-devel@m.gmane.org; Wed, 14 Apr 2010 12:58:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O25uL-0000aZ-Bt for emacs-devel@gnu.org; Wed, 14 Apr 2010 12:57:45 -0400 Original-Received: from [140.186.70.92] (port=40559 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O25uI-0000WG-LQ for emacs-devel@gnu.org; Wed, 14 Apr 2010 12:57:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O25uG-0000pu-DE for emacs-devel@gnu.org; Wed, 14 Apr 2010 12:57:42 -0400 Original-Received: from smtp-out2.starman.ee ([85.253.0.4]:59753 helo=mx2.starman.ee) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O25uG-0000pH-7b for emacs-devel@gnu.org; Wed, 14 Apr 2010 12:57:40 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.69.110.cable.starman.ee [82.131.69.110]) by mx2.starman.ee (Postfix) with ESMTP id B6AD33F4132; Wed, 14 Apr 2010 19:57:35 +0300 (EEST) In-Reply-To: (Stefan Monnier's message of "Sat, 10 Apr 2010 10:51:43 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123654 Archived-At: >>> Please add a new variable so we can do >>> && NILP (Fmemq (current_kboard->Vlast_command, Vnewvariable)) >>> and let Lisp packages add their commands to that variable. > >> A new variable is added in this patch (that includes other changes as well): > > Looks good, thank you, Looking now at such lines: (put 'scroll-up-command 'isearch-scroll t) (add-to-list 'scroll-preserve-screen-position-commands 'scroll-up-command) suggests that something is wrong here. Even though pager.el uses a list variable to define scrolling commands, we already use symbol properties to define scrolling commands for isearch. So now it looks too ugly to use different methods to do the same thing. Wouldn't it better to define scrolling commands for scroll-preserve-screen-position the same way with symbol properties? -- Juri Linkov http://www.jurta.org/emacs/