Re: /srv/bzr/emacs/trunk r111349: * lisp/progmodes/cperl-mode.el (cperl-calculate-indent): Do not stagger

Re: /srv/bzr/emacs/trunk r111349: * lisp/progmodes/cperl-mode.el (cperl-calculate-indent): Do not stagger

[Dmitry Gutov]

Hi Sam,

Sam Steingold <sds@gnu.org> writes:
> ------------------------------------------------------------
> revno: 111349
> committer: Sam Steingold <sds@gnu.org>
> branch nick: trunk
> timestamp: Thu 2012-12-27 11:33:06 -0500
> message:
>   * lisp/progmodes/cperl-mode.el (cperl-calculate-indent): Do not stagger
>   continuations, see <http://stackoverflow.com/questions/3582436>.
> modified:
>   lisp/ChangeLog
>   lisp/progmodes/cperl-mode.el
> === modified file 'lisp/ChangeLog'
> --- a/lisp/ChangeLog	2012-12-27 08:21:08 +0000
> +++ b/lisp/ChangeLog	2012-12-27 16:33:06 +0000
> @@ -1,8 +1,13 @@
> +2012-12-27  Sam Steingold  <sds@gnu.org>
> +
> +	* progmodes/cperl-mode.el (cperl-calculate-indent): Do not stagger
> +	continuations, see <http://stackoverflow.com/questions/3582436>.
> +
>  2012-12-27  Dmitry Gutov  <dgutov@yandex.ru>
>  
>  	* progmodes/ruby-mode.el (ruby-indent-beg-re): Only allow "class",
>  	"module" and "def" to have indentation before them.  Regression
> -	from 109911 (see the new test).
> +	from Bug#109911 (see the new test).

This change is inaccurate. 109911 is a Bazaar revision, not a bug number.

Re: /srv/bzr/emacs/trunk r111349: * lisp/progmodes/cperl-mode.el (cperl-calculate-indent): Do not stagger

[Juri Linkov]

>> -	from 109911 (see the new test).
>> +	from Bug#109911 (see the new test).
>
> This change is inaccurate. 109911 is a Bazaar revision, not a bug number.

To avoid ambiguity and misunderstanding revisions should have a prefix
similar to bug numbers, e.g. revno#109911 or revno:109911.

Re: /srv/bzr/emacs/trunk r111349: * lisp/progmodes/cperl-mode.el (cperl-calculate-indent): Do not stagger

[Sam Steingold]

> * Juri Linkov <whev@whegn.bet> [2012-12-27 21:39:29 +0200]:
>
>>> -	from 109911 (see the new test).
>>> +	from Bug#109911 (see the new test).
>>
>> This change is inaccurate. 109911 is a Bazaar revision, not a bug number.
>
> To avoid ambiguity and misunderstanding revisions should have a prefix
> similar to bug numbers, e.g. revno#109911 or revno:109911.

Thanks, fixed.

-- 
Sam Steingold (http://sds.podval.org/) on Ubuntu 12.04 (precise) X 11.0.11103000
http://www.childpsy.net/ http://ffii.org http://dhimmi.com
http://openvotingconsortium.org http://honestreporting.com http://memri.org
main(a){printf(a,34,a="main(a){printf(a,34,a=%c%s%c,34);}",34);}

Re: /srv/bzr/emacs/trunk r111349: * lisp/progmodes/cperl-mode.el (cperl-calculate-indent): Do not stagger

[Dmitry Gutov]

Juri Linkov <juri@jurta.org> writes:

>>> -	from 109911 (see the new test).
>>> +	from Bug#109911 (see the new test).
>>
>> This change is inaccurate. 109911 is a Bazaar revision, not a bug number.
>
> To avoid ambiguity and misunderstanding revisions should have a prefix
> similar to bug numbers, e.g. revno#109911 or revno:109911.

Thanks, will do next time.
I guess I'm used to Git, where you don't usually prefix commit ids with
anything.

bug-reference and revisions

[Juri Linkov]

>>>> -	from 109911 (see the new test).
>>>> +	from Bug#109911 (see the new test).
>>>
>>> This change is inaccurate. 109911 is a Bazaar revision, not a bug number.
>>
>> To avoid ambiguity and misunderstanding revisions should have a prefix
>> similar to bug numbers, e.g. revno#109911 or revno:109911.
>
> Thanks, will do next time.
> I guess I'm used to Git, where you don't usually prefix commit ids with
> anything.

Support for links to revision numbers could be added to bug-reference.el
to fontify strings like "revno:109911" where clicking on them will open
http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/109911

This is possible with a small patch that adds these formats:

revno#109911
revno:109911
revision#109911
revision:109911

=== modified file 'lisp/progmodes/bug-reference.el'
--- lisp/progmodes/bug-reference.el	2012-10-06 20:30:27 +0000
+++ lisp/progmodes/bug-reference.el	2012-12-27 22:43:01 +0000
@@ -69,7 +69,7 @@ (put 'bug-reference-url-format 'safe-loc
                 (get s 'bug-reference-url-format)))))
 
 (defcustom bug-reference-bug-regexp
-  "\\([Bb]ug ?#\\|[Pp]atch ?#\\|RFE ?#\\|PR [a-z-+]+/\\)\\([0-9]+\\(?:#[0-9]+\\)?\\)"
+  "\\([Bb]ug ?#\\|[Pp]atch ?#\\|[Rr]ev\\(?:no\\|ision\\) ?[#:]\\|RFE ?#\\|PR [a-z-+]+/\\)\\([0-9]+\\(?:#[0-9]+\\)?\\)"
   "Regular expression matching bug references.
 The second subexpression should match the bug reference (usually a number)."
   :type 'string


Then evaluating this will open the link:
(setq bug-reference-url-format
      "http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/%s")

but unfortunately it will override "http://debbugs.gnu.org/%s".

To handle two URL types requires customizing `bug-reference-url-format'
to a function that would decide which URL format to use.

Re: bug-reference and revisions

[Dmitry Gutov]

On 28.12.2012 2:45, Juri Linkov wrote:
>>>>> -	from 109911 (see the new test).
>>>>> +	from Bug#109911 (see the new test).
>>>>
>>>> This change is inaccurate. 109911 is a Bazaar revision, not a bug number.
>>>
>>> To avoid ambiguity and misunderstanding revisions should have a prefix
>>> similar to bug numbers, e.g. revno#109911 or revno:109911.
>>
>> Thanks, will do next time.
>> I guess I'm used to Git, where you don't usually prefix commit ids with
>> anything.
>
> Support for links to revision numbers could be added to bug-reference.el
> to fontify strings like "revno:109911" where clicking on them will open
> http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/109911

That would be nice.

> This is possible with a small patch that adds these formats:
>
 > ...
 >
> Then evaluating this will open the link:
> (setq bug-reference-url-format
>        "http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/%s")
>
> but unfortunately it will override "http://debbugs.gnu.org/%s".
>
> To handle two URL types requires customizing `bug-reference-url-format'
> to a function that would decide which URL format to use.

Why not add a function that would do exactly that and then set 
bug-reference-url-format to it in .dir-locals.el?

Re: /srv/bzr/emacs/trunk r111349: * lisp/progmodes/cperl-mode.el (cperl-calculate-indent): Do not stagger

[Stephen J. Turnbull]

Dmitry Gutov writes:
 > Juri Linkov <juri@jurta.org> writes:
 > 
 > >>> -	from 109911 (see the new test).
 > >>> +	from Bug#109911 (see the new test).
 > >>
 > >> This change is inaccurate. 109911 is a Bazaar revision, not a bug number.
 > >
 > > To avoid ambiguity and misunderstanding revisions should have a prefix
 > > similar to bug numbers, e.g. revno#109911 or revno:109911.
 > 
 > Thanks, will do next time.
 > I guess I'm used to Git, where you don't usually prefix commit ids with
 > anything.

Are those strings valid syntax for referencing bzr revisions (eg in
log or checkout)?  It would be best to standardize on valid syntax
(eg, for cut and paste).  Only rarely useful, I suppose, but ...

Re: /srv/bzr/emacs/trunk r111349: * lisp/progmodes/cperl-mode.el (cperl-calculate-indent): Do not stagger

[Xue Fuqiao]

On Fri, 28 Dec 2012 09:49:47 +0900
"Stephen J. Turnbull" <stephen@xemacs.org> wrote:

> Are those strings valid syntax for referencing bzr revisions (eg in
> log or checkout)?

for log:
% bzr log -r 1000..          # Revision 1000 and everything after it
% bzr log -r ..1000          # Everything up to and including r1000
% bzr log -r 1000..1100      # changes from 1000 to 1100
% bzr log -r 1000            # The changes in only revision 1000

And `bzr checkout' is seldom used.
-- 
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao

Re: /srv/bzr/emacs/trunk r111349: * lisp/progmodes/cperl-mode.el (cperl-calculate-indent): Do not stagger

[Stephen J. Turnbull]

Xue Fuqiao writes:
 > On Fri, 28 Dec 2012 09:49:47 +0900
 > "Stephen J. Turnbull" <stephen@xemacs.org> wrote:
 > 
 > > Are those strings valid syntax for referencing bzr revisions (eg in
 > > log or checkout)?
 > 
 > for log:
 > % bzr log -r 1000..          # Revision 1000 and everything after it

Read "bzr help revisionspec".  revno:1 is mentioned, revno#1 is not.
That's why I asked.

 > And `bzr checkout' is seldom used.

Actually, I do "$VCS checkout/update -r $REVSPEC" a lot in projects
where review takes place after the commit.  That's precisely why I
would want valid syntax in log messages.