From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111707: * doc-view.el: Use (and prefer) soffice as default ODF->PDF Date: Mon, 11 Feb 2013 09:06:01 +0530 Message-ID: <87y5evmsim.fsf@gmail.com> References: <877gmgbl4h.fsf@bzg.ath.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1360553797 11737 80.91.229.3 (11 Feb 2013 03:36:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Feb 2013 03:36:37 +0000 (UTC) Cc: Bastien , Tassilo Horn , Stefan Monnier , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 11 04:36:57 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U4kCP-0002CB-5S for ged-emacs-devel@m.gmane.org; Mon, 11 Feb 2013 04:36:57 +0100 Original-Received: from localhost ([::1]:40227 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4kC5-0002Ui-UM for ged-emacs-devel@m.gmane.org; Sun, 10 Feb 2013 22:36:37 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4kC3-0002Ub-FZ for emacs-devel@gnu.org; Sun, 10 Feb 2013 22:36:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4kC1-0001Xo-O3 for emacs-devel@gnu.org; Sun, 10 Feb 2013 22:36:35 -0500 Original-Received: from mail-pa0-f42.google.com ([209.85.220.42]:55300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4kBz-0001XT-Rq; Sun, 10 Feb 2013 22:36:31 -0500 Original-Received: by mail-pa0-f42.google.com with SMTP id kq12so2938089pab.29 for ; Sun, 10 Feb 2013 19:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=BTizF+rPmz2nZRkarUvgj3LGPQXhAGcJ0CEB6XnZyTw=; b=naaeU644uEn4odTV/XFoVf2sszWUSr3j+cOduYalkBWBPlqC9wa3IdBNdfz3KG+qeJ F4eWX1AYtk9oaW8OcJx5UQMenYOS6icYGcKBPGIDJIGFKPPq2TiRuZQXkV5JCs/OILPU SHwHexY1/1q26v5zUtJZYpDpaUBVHMLkjXCZb0K4b8hPihqplIdHO1nRalcuzp8tv0IY FNjBQPQxW8t7t5Y9k2RSDV4sZfzdiM4BM5UCzCSyCJjEd0OWPdICHnJ+c62pVcUg3Fao Ny6cxnEZvsClmtSgkgBO+9l+tkKrNZm0Sz2luL76QMOUPaGC1oWOl1xKDWAHs3b7OeK0 4nFw== X-Received: by 10.68.191.226 with SMTP id hb2mr15416337pbc.108.1360553790719; Sun, 10 Feb 2013 19:36:30 -0800 (PST) Original-Received: from debian-6.05 ([115.241.62.28]) by mx.google.com with ESMTPS id gj10sm6211196pbc.0.2013.02.10.19.36.25 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Sun, 10 Feb 2013 19:36:28 -0800 (PST) In-Reply-To: (Glenn Morris's message of "Sun, 10 Feb 2013 15:51:04 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.220.42 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156954 Archived-At: Glenn Morris writes: > Bastien wrote: > >>> PS I think it's impossible to have unoconv without soffice, so this >>> change amounts to "always use soffice". >> >> I'm not sure I get the logic here: you need to have soffice installed >> if you want to use unoconv, but being able to use unoconv instead of >> soffice is good. So as I understand it, the change does not amount >> to "always use soffice", does it? > > (cond > ((executable-find "soffice") "soffice") > ((executable-find "unoconv") "unoconv") > (t "soffice")) > > It is impossible for this to return anything but "soffice". > IMO it should be: > > (or (executable-find "unoconv") "soffice") I didn't put deliberate thought in what the order should be. My patch WILL require tweaks on a case-by-case basis. My immediate focus was to get the functionality in. I invite people with commit access to fix "minor issues" without much ado. soffice comes from libreoffice-common ,---- | kjambunathan@debian-6:~$ dpkg -S /usr/bin/soffice | libreoffice-common: /usr/bin/soffice `---- unoconv does NOT depend on libreoffice-common ,---- | kjambunathan@debian-6:~$ apt-rdepends unoconv | grep libre | Reading package lists... Done | Building dependency tree | Reading state information... Done | Depends: libreadline6 (>= 6.0) | libreadline6 `---- unoconv instread depends on openoffice.org packages ,---- | kjambunathan@debian-6:~$ apt-rdepends unoconv | grep office | Reading package lists... Done | Building dependency tree | Reading state information... Done | Depends: openoffice.org-core (= 1:3.2.1-11+squeeze7) | openoffice.org-core | Depends: openoffice.org-common (>> 1:3.2.1) | openoffice.org-common | Depends: openoffice.org-style | Depends: openoffice.org-style-default | openoffice.org-style | openoffice.org-style-default `---- I see an soffice.sh in /etc/openoffice/soffice.sh ,---- | kjambunathan@debian-6:~$ dpkg -L openoffice.org-common | /etc | /etc/bash_completion.d | /etc/bash_completion.d/ooffice.sh | /etc/openoffice | /etc/openoffice/sofficerc | /etc/openoffice/psprint.conf | /etc/openoffice/soffice.sh | kjambunathan@debian-6:~$ `---- > > --