From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Edebug-x visual extensions to Edebug Date: Tue, 12 Mar 2013 15:10:23 +0100 Message-ID: <87y5dsyai8.fsf@thinkpad.tsdh.de> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1363097437 9087 80.91.229.3 (12 Mar 2013 14:10:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Mar 2013 14:10:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Scott Barnett Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 12 15:10:59 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UFPur-0008FE-9u for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 15:10:57 +0100 Original-Received: from localhost ([::1]:42500 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFPuU-0003rL-TJ for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 10:10:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFPuP-0003rD-Sj for emacs-devel@gnu.org; Tue, 12 Mar 2013 10:10:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFPuL-0000DE-Bp for emacs-devel@gnu.org; Tue, 12 Mar 2013 10:10:29 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:34332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFPuL-0000Cm-5t for emacs-devel@gnu.org; Tue, 12 Mar 2013 10:10:25 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 410161A84C7; Tue, 12 Mar 2013 15:10:24 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Original-Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wc_jaKI9cid0; Tue, 12 Mar 2013 15:10:23 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Original-Received: from thinkpad.tsdh.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id D7C9F1A84C4; Tue, 12 Mar 2013 15:10:23 +0100 (CET) Mail-Followup-To: Scott Barnett , emacs-devel@gnu.org In-Reply-To: (Scott Barnett's message of "Tue, 12 Mar 2013 22:56:13 +1100") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 141.26.64.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157775 Archived-At: Scott Barnett writes: Hi! > I made a small extension to Edebug that highlights breakpoints, shows > a list of currently instrumented functions and provides a couple of > other extras to make Edebug easier for me to use. Sounds great! > If this is something that should be included please let me know of the > next steps. Except for the copyright assignment, there are at least two things I can spot while glancing at the code that hinder its inclusion in emacs proper. The first one is that you shouldn't require cl, and the second is the dependency to the external dash package. With emacs 24 you can use `cl-restructuring-bind' and `cl-find-if' instead of the unprefixed versions. Instead of dash's `-each' you can use `mapc', instead of `-map' you can use `mapcar', instead of `-remove' you can use `cl-remove-if', and instead of `-contains?' you can use `member'. Bye, Tassilo