From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vitalie Spinu Newsgroups: gmane.emacs.devel Subject: Re: fix for bug 10994 breaks ido customizations in major way Date: Tue, 07 May 2013 21:00:43 +0200 Organization: EUR Message-ID: <87y5bqty1w.fsf@gmail.com> References: <87txmfyb9n.fsf@gmail.com> <432AFE3B3321498E9B17075D3B55A60B@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1367953262 31221 80.91.229.3 (7 May 2013 19:01:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 May 2013 19:01:02 +0000 (UTC) Cc: Leo Liu , Drew Adams , emacs-devel@gnu.org To: Le Wang Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 07 21:01:02 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UZn8F-00077Z-D3 for ged-emacs-devel@m.gmane.org; Tue, 07 May 2013 21:00:59 +0200 Original-Received: from localhost ([::1]:51328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZn8E-0008WC-OC for ged-emacs-devel@m.gmane.org; Tue, 07 May 2013 15:00:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZn86-0008VU-8B for emacs-devel@gnu.org; Tue, 07 May 2013 15:00:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZn82-000239-5n for emacs-devel@gnu.org; Tue, 07 May 2013 15:00:49 -0400 Original-Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:59161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZn81-00022w-SB for emacs-devel@gnu.org; Tue, 07 May 2013 15:00:46 -0400 Original-Received: by mail-we0-f169.google.com with SMTP id x54so951298wes.28 for ; Tue, 07 May 2013 12:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=A5RW65yqLheONCvSHRwqZ1zgnueo/XDXjY9z9YZdYSs=; b=GC8XvJ1LaCxgz2kAOL2MxT4Evrdy2xZYr4u7YbxgHd2I6YthwVpdwR9CBGQTMdEcUB McRXYrD3UdEK8lHKjDWbrow/u5/LTI5HWQbvL7mCvgBSbxUgiCWRv/4bp0wQwF5bIPHI IZcaLeii7kia2nmRuFodJxZow0BcZMqS7qxtJkIoj3KC33dVpoef7iiU0IwoyzP0nceH uvbKdNvGFQWFY6t8JwaVrNo+rT2AtOXPExJlvThee1ZqfX24lWdfhcSoiuY/TpEhXH0z NQVspR7KbOLgZdXufVYPN1djKNJ35PbntiprcVBRqQdIcyCYiakonqF1iy6fBtck9jzC M6PA== X-Received: by 10.180.212.46 with SMTP id nh14mr16759660wic.26.1367953245056; Tue, 07 May 2013 12:00:45 -0700 (PDT) Original-Received: from localhost (dhcp-077-249-018-128.chello.nl. [77.249.18.128]) by mx.google.com with ESMTPSA id x13sm5018598wib.3.2013.05.07.12.00.43 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 07 May 2013 12:00:44 -0700 (PDT) In-Reply-To: (Le Wang's message of "Tue, 7 May 2013 22:47:58 +0800") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159400 Archived-At: >> Le Wang >> on Tue, 7 May 2013 22:47:58 +0800 wrote: > Hi Drew, > On Tue, May 7, 2013 at 10:44 PM, Drew Adams wrote: >> I don't care much about Ido, so I don't have an opinion about the question at >> hand. >> >> However, I will say that it is NOT at all the case that there is nothing out >> there, in the wild, that takes advantage of completion candidates that have the >> same text (same string chars) Indeed, it is not difficult to imagine an application when same names have different faces. > We can say with certainty that there is "nothing in the wild" because > there is a bug in the latest released Emacs and ido that does not work > with duplicate strings. This is your subjective opinion. The current state is a very reasonable default, it does *work* (aka cycles) with duplicated strings, and call this behavior a bug is at least inappropriate. To have useless properties that are not needed by your application and rely on IDO to delete those for you is a bad and lazy style. So the applications that you mention are buggy, not IDO. Don't want duplicated names, pass through delete-dups before calling ido-completing-read, or even better, don't collect those properties in the first place. Not a big deal. What you propose will force *every* implementation out there to explicitly deal with duplicated strings. As said before, if they have duplicated strings they have them for a reason (even if it is simple laziness). Don't you see that you propose to cut some of the programmers' and users' flexibility? Vitalie