From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: add keyword search and display in details for list-packages Date: Fri, 22 Nov 2013 10:13:40 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87y54g8o63.fsf@flea.lifelogs.com> References: <87wql1w6io.fsf@flea.lifelogs.com> <87r4axu4dm.fsf@flea.lifelogs.com> <87k3gorvs4.fsf@flea.lifelogs.com> <87eh6adbqr.fsf@flea.lifelogs.com> <87a9gyc8pp.fsf_-_@flea.lifelogs.com> <87txf5butd.fsf@flea.lifelogs.com> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1385133192 31528 80.91.229.3 (22 Nov 2013 15:13:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Nov 2013 15:13:12 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 22 16:13:18 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VjsQ1-000400-PK for ged-emacs-devel@m.gmane.org; Fri, 22 Nov 2013 16:13:18 +0100 Original-Received: from localhost ([::1]:39378 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjsQ1-00089y-AV for ged-emacs-devel@m.gmane.org; Fri, 22 Nov 2013 10:13:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjsPt-00089b-Eu for emacs-devel@gnu.org; Fri, 22 Nov 2013 10:13:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjsPl-0006Fl-E7 for emacs-devel@gnu.org; Fri, 22 Nov 2013 10:13:09 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:47698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjsPl-0006FN-3d for emacs-devel@gnu.org; Fri, 22 Nov 2013 10:13:01 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1VjsPi-0003mS-7f for emacs-devel@gnu.org; Fri, 22 Nov 2013 16:12:58 +0100 Original-Received: from c-98-229-61-72.hsd1.ma.comcast.net ([98.229.61.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 22 Nov 2013 16:12:58 +0100 Original-Received: from tzz by c-98-229-61-72.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 22 Nov 2013 16:12:58 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 68 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-98-229-61-72.hsd1.ma.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:dEx73MKYXYnYepUUX9BPMONJOY8= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165564 Archived-At: --=-=-= Content-Type: text/plain On Thu, 21 Nov 2013 20:23:13 -0500 Stefan Monnier wrote: SM> Not sure how you plan to do that. >> I was thinking of appending "k1,k2,..." to the description. SM> But that means it'll be "out of view" in many/most cases. Not sure it's SM> worth the trouble. Well, it would be visible at least... better than having to hit `?' on every package. Maybe it can be toggled as an addition or as a column instead with `k' in the packages listing? >> (1) works for me as well. Do you or I need to do work on the backend >> tools to make it happen? That's the prerequisite for the other work >> listed here, which I can do on my own afterwards. SM> If you can work on the elpa/admin/* scripts to make them DTRT, then I'll SM> take care of installing them in elpa.gnu.org. It was hard to get around the compilation failure of `packages/diff-hl'. I had to remove it temporarily in order to test the `make' output. Is there a way to do "make ignore-errors" in ELPA? I tested with this commit as HEAD: 30809c7e797f57c50a63f64ac19eb8b78bc21939 (master from today). Either way, I believe I added the keywords correctly, see the attached patch. But I couldn't test it properly, sorry :) Doing all combinations of `make clean; make; make archive-full' didn't refresh `archive-contents' with the keywords, even though they were in place. Maybe you can update the README or I'm missing something obvious? Thanks Ted --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=elpa-include-keywords.patch diff --git a/admin/archive-contents.el b/admin/archive-contents.el index 7ee9c1c..8fee66b 100644 --- a/admin/archive-contents.el +++ b/admin/archive-contents.el @@ -187,13 +187,18 @@ Otherwise, return nil." (requires-str (lm-header "package-requires")) (pt (lm-header "package-type")) (simple (if pt (equal pt "simple") (= (length files) 1))) + (keywords (split-string (or (lm-header "keywords") "") + "," t "[ ]+")) (url (or (lm-header "url") (format "http://elpa.gnu.org/packages/%s.html" pkg))) (req (if requires-str (mapcar 'archive--convert-require (car (read-from-string requires-str)))))) - (list simple version description req (list (cons :url url))))))) + (list simple version description req + ;; extra parameters + (list (cons :url url) + (cons :keywords keywords))))))) ((not (file-exists-p pkg-file)) (error "Can find single file nor package desc file in %s" dir))))) --=-=-=--