From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: The fixes-bug field Date: Fri, 17 Jan 2014 18:20:51 +0100 Message-ID: <87y52esex8.fsf@building.gnus.org> References: <20140116141315.CA3BE380835@snark.thyrsus.com> <20140116163011.GC17303@thyrsus.com> <83d2jr3ly9.fsf@gnu.org> <20140116180809.GB17770@thyrsus.com> <8338kn3ha8.fsf@gnu.org> <20140116200456.GK17770@thyrsus.com> <83zjmv1upy.fsf@gnu.org> <20140116214714.GA19493@thyrsus.com> <83sisn12sk.fsf@gnu.org> <52D8E29F.6040004@cs.ucla.edu> <87mwiuzjm0.fsf@building.gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389979311 8318 80.91.229.3 (17 Jan 2014 17:21:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jan 2014 17:21:51 +0000 (UTC) Cc: esr@thyrsus.com, Eli Zaretskii , Paul Eggert , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 17 18:21:54 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W4D78-0004js-I0 for ged-emacs-devel@m.gmane.org; Fri, 17 Jan 2014 18:21:50 +0100 Original-Received: from localhost ([::1]:39368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4D78-0002s6-5K for ged-emacs-devel@m.gmane.org; Fri, 17 Jan 2014 12:21:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4D70-0002rR-Iv for emacs-devel@gnu.org; Fri, 17 Jan 2014 12:21:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W4D6v-0000sh-5d for emacs-devel@gnu.org; Fri, 17 Jan 2014 12:21:42 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:51291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4D6u-0000sX-VI; Fri, 17 Jan 2014 12:21:37 -0500 Original-Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1W4D6e-0007g7-UE; Fri, 17 Jan 2014 18:21:21 +0100 In-Reply-To: (Stefan Monnier's message of "Fri, 17 Jan 2014 11:12:25 -0500") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1W4D6e-0007g7-UE MailScanner-NULL-Check: 1390584081.66728@YUtLZVEJmBXsrtl7DaTVyg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168634 Archived-At: Stefan Monnier writes: > IOW, in many/most situations I only find out after committing that the > patch really fixes the bug. So it would work if the "fixes bug#NNN" can > be added via something like "git notes", but it won't work well in the > commit message itself. Well, I usually close the bug report after I think I've fixed the bug. If it turns out that I'm wrong, bugs can be reopened. But in the vast majority of the cases, I'm right. (Ahem.) If we're unsure, there's nothing to stop us from committing something that just mentions the bug without "fixes". -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/