* Re: emacs-devel@gnu.org [not found] ` <20141201202026.GA2794@thyrsus.com> @ 2014-12-01 20:30 ` Lars Magne Ingebrigtsen 2014-12-01 22:09 ` emacs-devel@gnu.org Eric S. Raymond 0 siblings, 1 reply; 6+ messages in thread From: Lars Magne Ingebrigtsen @ 2014-12-01 20:30 UTC (permalink / raw) To: Eric S. Raymond; +Cc: emacs-devel "Eric S. Raymond" <esr@thyrsus.com> writes: > Lars Magne Ingebrigtsen <larsi@gnus.org>: >> esr@snark.thyrsus.com (Eric S. Raymond) writes: >> >> > I just restored vc-bzr-state-heuristic. Confirm tht this unbreaks things? >> >> I does; thanks. > > Now I need to try to figure out (a) why removing it broke things, and > (b) why it disn't break anything where I coulse see it. That is concerning. It's because `(vc-bzr-file-name-relative "~/rmz.jpg")' returns nil for me. What does it say for you? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-devel@gnu.org 2014-12-01 20:30 ` emacs-devel@gnu.org Lars Magne Ingebrigtsen @ 2014-12-01 22:09 ` Eric S. Raymond 2014-12-01 22:21 ` emacs-devel@gnu.org Lars Magne Ingebrigtsen 0 siblings, 1 reply; 6+ messages in thread From: Eric S. Raymond @ 2014-12-01 22:09 UTC (permalink / raw) To: Lars Magne Ingebrigtsen; +Cc: emacs-devel Lars Magne Ingebrigtsen <larsi@gnus.org>: > > Now I need to try to figure out (a) why removing it broke things, and > > (b) why it disn't break anything where I coulse see it. That is concerning. > > It's because `(vc-bzr-file-name-relative "~/rmz.jpg")' returns nil for > me. What does it say for you? Same; nil. -- <a href="http://www.catb.org/~esr/">Eric S. Raymond</a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-devel@gnu.org 2014-12-01 22:09 ` emacs-devel@gnu.org Eric S. Raymond @ 2014-12-01 22:21 ` Lars Magne Ingebrigtsen 2014-12-02 9:42 ` emacs-devel@gnu.org David Kastrup 0 siblings, 1 reply; 6+ messages in thread From: Lars Magne Ingebrigtsen @ 2014-12-01 22:21 UTC (permalink / raw) To: Eric S. Raymond; +Cc: emacs-devel "Eric S. Raymond" <esr@thyrsus.com> writes: > Lars Magne Ingebrigtsen <larsi@gnus.org>: >> > Now I need to try to figure out (a) why removing it broke things, and >> > (b) why it disn't break anything where I coulse see it. That is concerning. >> >> It's because `(vc-bzr-file-name-relative "~/rmz.jpg")' returns nil for >> me. What does it say for you? > > Same; nil. Well, looking at the code, `vc-bzr-state' calls `vc-bzr-status' first, which does `(regexp-quote (vc-bzr-file-name-relative file))', and if that function returns nil for you, then `regexp-quote' should signal an error, since that's not a valid input. So `(vc-bzr-state file)' should signal an error for you. :-) Unless I'm totally misreading the code, which is, of course, possible. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-devel@gnu.org 2014-12-01 22:21 ` emacs-devel@gnu.org Lars Magne Ingebrigtsen @ 2014-12-02 9:42 ` David Kastrup 2014-12-02 10:49 ` emacs-devel@gnu.org Andreas Schwab 0 siblings, 1 reply; 6+ messages in thread From: David Kastrup @ 2014-12-02 9:42 UTC (permalink / raw) To: emacs-devel Lars Magne Ingebrigtsen <larsi@gnus.org> writes: > "Eric S. Raymond" <esr@thyrsus.com> writes: > >> Lars Magne Ingebrigtsen <larsi@gnus.org>: >>> > Now I need to try to figure out (a) why removing it broke things, and >>> > (b) why it disn't break anything where I coulse see it. That is concerning. >>> >>> It's because `(vc-bzr-file-name-relative "~/rmz.jpg")' returns nil for >>> me. What does it say for you? >> >> Same; nil. > > Well, looking at the code, `vc-bzr-state' calls `vc-bzr-status' first, > which does `(regexp-quote (vc-bzr-file-name-relative file))', and if > that function returns nil for you, then `regexp-quote' should signal an > error, since that's not a valid input. > > So `(vc-bzr-state file)' should signal an error for you. :-) > > Unless I'm totally misreading the code, which is, of course, possible. Or he has everything under Git anyway so that his Emacs does not bother checking for other version control system. -- David Kastrup ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-devel@gnu.org 2014-12-02 9:42 ` emacs-devel@gnu.org David Kastrup @ 2014-12-02 10:49 ` Andreas Schwab 2014-12-02 11:27 ` vc-bzr-state Ivan Shmakov 0 siblings, 1 reply; 6+ messages in thread From: Andreas Schwab @ 2014-12-02 10:49 UTC (permalink / raw) To: David Kastrup; +Cc: emacs-devel David Kastrup <dak@gnu.org> writes: > Lars Magne Ingebrigtsen <larsi@gnus.org> writes: > >> "Eric S. Raymond" <esr@thyrsus.com> writes: >> >>> Lars Magne Ingebrigtsen <larsi@gnus.org>: >>>> > Now I need to try to figure out (a) why removing it broke things, and >>>> > (b) why it disn't break anything where I coulse see it. That is concerning. >>>> >>>> It's because `(vc-bzr-file-name-relative "~/rmz.jpg")' returns nil for >>>> me. What does it say for you? >>> >>> Same; nil. >> >> Well, looking at the code, `vc-bzr-state' calls `vc-bzr-status' first, >> which does `(regexp-quote (vc-bzr-file-name-relative file))', and if >> that function returns nil for you, then `regexp-quote' should signal an >> error, since that's not a valid input. >> >> So `(vc-bzr-state file)' should signal an error for you. :-) >> >> Unless I'm totally misreading the code, which is, of course, possible. > > Or he has everything under Git anyway so that his Emacs does not bother > checking for other version control system. vc-handled-backends has Bzr listed before Git. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 6+ messages in thread
* vc-bzr-state 2014-12-02 10:49 ` emacs-devel@gnu.org Andreas Schwab @ 2014-12-02 11:27 ` Ivan Shmakov 0 siblings, 0 replies; 6+ messages in thread From: Ivan Shmakov @ 2014-12-02 11:27 UTC (permalink / raw) To: emacs-devel >>>>> Andreas Schwab <schwab@linux-m68k.org> writes: […] >>> So `(vc-bzr-state file)' should signal an error for you. :-) >>> Unless I'm totally misreading the code, which is, of course, >>> possible. >> Or he has everything under Git anyway so that his Emacs does not >> bother checking for other version control system. This should in no way change the behavior of an explicit call to a backend function, such as vc-bzr-state. > vc-handled-backends has Bzr listed before Git. Unless set otherwise. vc-handled-backends (Git MW CVS SVN SCCS Bzr Hg Arch RCS) -- FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-02 11:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20141201195401.3A72F3832EA@snark.thyrsus.com>
[not found] ` <m37fyb16wd.fsf@stories.gnus.org>
[not found] ` <20141201202026.GA2794@thyrsus.com>
2014-12-01 20:30 ` emacs-devel@gnu.org Lars Magne Ingebrigtsen
2014-12-01 22:09 ` emacs-devel@gnu.org Eric S. Raymond
2014-12-01 22:21 ` emacs-devel@gnu.org Lars Magne Ingebrigtsen
2014-12-02 9:42 ` emacs-devel@gnu.org David Kastrup
2014-12-02 10:49 ` emacs-devel@gnu.org Andreas Schwab
2014-12-02 11:27 ` vc-bzr-state Ivan Shmakov
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).