From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region Date: Sun, 28 Feb 2016 17:21:04 +1100 Message-ID: <87y4a5s6cv.fsf@gnus.org> References: <1456189471-18273-1-git-send-email-mitch.special@gmail.com> <87egbxid4e.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456640525 16315 80.91.229.3 (28 Feb 2016 06:22:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Feb 2016 06:22:05 +0000 (UTC) Cc: Kristoffer Gronlund , emacs-devel@gnu.org To: Mitchel Humpherys Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 28 07:21:50 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aZujl-0002BK-37 for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2016 07:21:49 +0100 Original-Received: from localhost ([::1]:57685 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZujk-0000ml-Ca for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2016 01:21:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZujX-0000mg-Co for emacs-devel@gnu.org; Sun, 28 Feb 2016 01:21:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZujU-0005ST-7z for emacs-devel@gnu.org; Sun, 28 Feb 2016 01:21:35 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:58797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZujU-0005SP-1C for emacs-devel@gnu.org; Sun, 28 Feb 2016 01:21:32 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aZuj7-0004Jo-7C; Sun, 28 Feb 2016 07:21:09 +0100 In-Reply-To: <87egbxid4e.fsf@gmail.com> (Mitchel Humpherys's message of "Sat, 27 Feb 2016 22:05:05 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aZuj7-0004Jo-7C MailScanner-NULL-Check: 1457245270.21544@wYOocmZLLyBue5X1eXH8lQ X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200745 Archived-At: Mitchel Humpherys writes: > On Mon, Feb 22 2016 at 05:04:31 PM, Mitchel Humpherys > wrote: >> Setting a foreground color on the `region' face is slightly annoying. >> This is subjective, of course, but the consensus among other themes and >> around the web is to *not* set a foreground color on the region face. > > Any objections to this? I should have mentioned that the reason it's > slightly annoying is because setting a foreground color hides existing > syntax highlighting within the region text. The patch sounds OK to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no