From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mario Lang Newsgroups: gmane.emacs.devel Subject: [elpa] packages/rudel/rudel-display.el:40:1:Error: eieio-oref called on a class: rudel-backend-factory Date: Sun, 10 Jul 2016 22:14:15 +0200 Message-ID: <87y459l088.fsf_-_@fx.delysid.org> References: <87zipsqtyt.fsf@fx.delysid.org> <577FF235.9040304@cs.ucla.edu> <87eg71myi7.fsf@fx.delysid.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1468181680 25741 80.91.229.3 (10 Jul 2016 20:14:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Jul 2016 20:14:40 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 10 22:14:32 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bML7Y-0005vN-0X for ged-emacs-devel@m.gmane.org; Sun, 10 Jul 2016 22:14:32 +0200 Original-Received: from localhost ([::1]:56763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bML7X-0001Os-1W for ged-emacs-devel@m.gmane.org; Sun, 10 Jul 2016 16:14:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bML7P-0001Ob-VT for emacs-devel@gnu.org; Sun, 10 Jul 2016 16:14:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bML7L-0007KJ-OJ for emacs-devel@gnu.org; Sun, 10 Jul 2016 16:14:22 -0400 Original-Received: from familiekainz.at ([91.121.101.210]:45672 helo=ks354034.kimsufi.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bML7L-0007KB-Hw for emacs-devel@gnu.org; Sun, 10 Jul 2016 16:14:19 -0400 Original-Received: from fx (unknown [80.109.194.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ks354034.kimsufi.com (Postfix) with ESMTPSA id E91B6BF626 for ; Sun, 10 Jul 2016 22:14:16 +0200 (CEST) Original-Received: from mlang by fx with local (Exim 4.87) (envelope-from ) id 1bML7H-0002c4-P9 for emacs-devel@gnu.org; Sun, 10 Jul 2016 22:14:15 +0200 In-Reply-To: (Thomas Fitzsimmons's message of "Sun, 10 Jul 2016 12:22:56 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) Importance: high X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 91.121.101.210 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205521 Archived-At: Hi. Now that fsm.el has been fixed (thanks), the elpa elc build fails in the ru= del package. The problem seems to be in `eieio-oref' which looks a bit strange to me: (defun eieio-oref (obj slot) "Return the value in OBJ at SLOT in the object vector." (declare (compiler-macro (lambda (exp) (ignore obj) (pcase slot ((and (or `',name (and name (pred keywordp))) (guard (not (memq name eieio--known-slot-names)))) (macroexp--warn-and-return (format-message "Unknown slot `%S'" name) exp 'compile-on= ly)) (_ exp))))) (cl-check-type slot symbol) (cl-check-type obj (or eieio-object class)) (let* ((class (cond ((symbolp obj) (error "eieio-oref called on a class: %s" obj) (let ((c (cl--find-class obj))) (if (eieio--class-p c) (eieio-class-un-autoload ob= j)) c)) (t (eieio--object-class obj)))) (c (eieio--slot-name-index class slot))) ...)) I have to admit that I don't grok eieio, but this piece of code looks suspicious. Wouldn't the code after the `error' call be dead? On a somewhat related note, package rudel could use a port to cl-lib and cl-generic. Would that be a worthwhile change to make? --=20 CYa, =E2=A1=8D=E2=A0=81=E2=A0=97=E2=A0=8A=E2=A0=95