Re: [PATCH] Make eshell ‘ls’ output clickable.

[Nicolas Petton <nicolas@petton.fr>]

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

Matthew Bauer <mjbauer95@gmail.com> writes:

Hi Matthew,

Thanks for the patch!

> It's debatable whether this is should be included in Eshell because it
> can fairlhy easily be provided with advising (see link below). My
> opinion, though, is that it's a fairly useful feature with fairly
> little cost and gives Eshell a more Dired-like feel.

I like the feature, I've been using something similar for a long time.
I would even enable it by default, as I don't see any downside of doing
so.

I've commented the patch below:

> +(defun eshell-ls-find-file-at-point (point)

The function name suggests that this function finds a file based on the
current position of the point, so I would remove the POINT argument,
change `(interactive "d")' to `(interactive)', and use the `point'
function.

> +  "RET on Eshell's `ls' output to open files.
> +POINT is the point that the file is available at."

The function does not bind `RET', as the docstring suggests.

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]