From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: Help with recursive destructive function
Date: Thu, 07 Jun 2018 09:51:09 -0700 [thread overview]
Message-ID: <87y3fqsfpe.fsf@ericabrahamsen.net> (raw)
In-Reply-To: jwvin6uhfcp.fsf-monnier+gmane.emacs.devel@gnu.org
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I think this function could be useful in many situations, so I'd like to
>> make it fairly general -- gv-refs or values.
>
> Why "or values"? It's easy for the caller to wrap its argument in
> `(gv-ref ...)` and lets the function be more efficient.
Fair enough, I guess I was just thinking gv-ref will be unfamiliar to
most people, but if the docstring is clear it doesn't matter.
>> How would you feel about gv-ref itself doing a check?
>>
>> (if (and (eq 'closure (caar place))
>> (eq 'closure (cadr place)))
>> place
>> (gv-letplace ...etc...)
>>
>> Too hacky?
>
> Beside the obvious problem of checking equality vs `closure` which will
> break down with byte-compiled code, the more serious problem is that
> this code is run at macro-expansion time, not at run-time, so `place` is
> a Elisp *expression* and not an Elisp *value*.
>
> IOW your test will only trigger when the *source code* is of the form
>
> (gv-ref ((closure ...) . (closure ...)))
Bleagh, okay. I will stop trying to be clever.
Thanks,
Eric
prev parent reply other threads:[~2018-06-07 16:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-05 1:04 Help with recursive destructive function Eric Abrahamsen
2018-05-05 1:18 ` Stefan Monnier
2018-05-05 1:37 ` Michael Heerdegen
2018-05-05 15:41 ` Michael Heerdegen
2018-05-06 17:29 ` Eric Abrahamsen
2018-05-06 19:29 ` Michael Heerdegen
2018-05-06 19:34 ` Eric Abrahamsen
2018-05-06 18:27 ` Eric Abrahamsen
2018-05-07 2:01 ` Michael Heerdegen
2018-05-07 3:01 ` Eric Abrahamsen
2018-05-07 4:16 ` Clément Pit-Claudel
2018-05-07 14:14 ` Michael Heerdegen
2018-05-07 16:26 ` Stefan Monnier
2018-05-07 16:52 ` Eric Abrahamsen
2018-05-08 13:15 ` Michael Heerdegen
2018-05-08 18:42 ` Eric Abrahamsen
2018-05-08 19:03 ` Clément Pit-Claudel
2018-05-08 19:41 ` Eric Abrahamsen
2018-05-10 1:52 ` Michael Heerdegen
2018-05-10 17:08 ` Michael Heerdegen
2018-05-11 2:12 ` Eric Abrahamsen
2018-05-14 14:27 ` Michael Heerdegen
2018-05-14 16:57 ` Eric Abrahamsen
2018-05-14 23:16 ` Michael Heerdegen
2018-05-15 0:28 ` Eric Abrahamsen
2018-07-28 20:52 ` Eric Abrahamsen
2018-07-28 23:46 ` Michael Heerdegen
2018-07-28 23:59 ` Eric Abrahamsen
2018-07-29 0:09 ` Michael Heerdegen
2018-06-04 22:28 ` Eric Abrahamsen
2018-06-05 0:23 ` Michael Heerdegen
2018-06-06 21:04 ` Eric Abrahamsen
2018-06-06 21:58 ` Michael Heerdegen
2018-06-06 22:10 ` Eric Abrahamsen
2018-06-06 23:10 ` Eric Abrahamsen
2018-06-06 23:30 ` Michael Heerdegen
2018-06-07 0:49 ` Eric Abrahamsen
2018-06-07 1:13 ` Michael Heerdegen
2018-06-06 23:18 ` Michael Heerdegen
2018-06-07 13:59 ` Stefan Monnier
2018-06-07 16:51 ` Eric Abrahamsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3fqsfpe.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).