From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Tue, 30 Oct 2018 18:22:48 +0100 Message-ID: <87y3aftklz.fsf@web.de> References: <83tvlcsnee.fsf@gnu.org> <86mur137n8.fsf@gmail.com> <20181029130132.GB4195@ACM> <20181029134722.GC4195@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1540920068 4285 195.159.176.226 (30 Oct 2018 17:21:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Oct 2018 17:21:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 30 18:21:04 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHXhP-00012Z-Oj for ged-emacs-devel@m.gmane.org; Tue, 30 Oct 2018 18:21:03 +0100 Original-Received: from localhost ([::1]:54595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHXjW-0005lw-BB for ged-emacs-devel@m.gmane.org; Tue, 30 Oct 2018 13:23:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHXjN-0005lc-8Y for emacs-devel@gnu.org; Tue, 30 Oct 2018 13:23:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHXjJ-0007eG-R4 for emacs-devel@gnu.org; Tue, 30 Oct 2018 13:23:05 -0400 Original-Received: from mout.web.de ([217.72.192.78]:58665) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHXjJ-0007bc-Cz for emacs-devel@gnu.org; Tue, 30 Oct 2018 13:23:01 -0400 Original-Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LpNwf-1ffAZr1eCL-00fEkB; Tue, 30 Oct 2018 18:22:50 +0100 Original-Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LpNwf-1ffAZr1eCL-00fEkB; Tue, 30 Oct 2018 18:22:50 +0100 In-Reply-To: (Stefan Monnier's message of "Mon, 29 Oct 2018 17:08:38 -0400") X-Provags-ID: V03:K1:0lBmJ0mTIzcKSvfbqfz2TCU2pAxKj0dCsVrbXE3ojYNQOpXoibs h+MC41meJWOl/Z7Q4DsawGN8JziSh2wQePC7EVtM0BXYJ6r0XOqw1xHD+AQq2MS7WHwM5KZ LuTOI/mpEkQJIw8st05rYUr/pPhHjlXhE99Jkyakra79wShHlK02jH51OjiFq/C41eXtf7x j+KHUdg1MTGmYZkTUgndg== X-UI-Out-Filterresults: notjunk:1;V01:K0:VmtFw8w1Jkc=:z2zziigh9hOf8fnhLZmCeZ r5XBWjuq+kTz2t/vNWPxgWOCgjbZ/DgvX3AfBDXjfHUGahMRlcXmwnrDAs7UE2e0cjlywY1+E Hk/1SB73l35ZCysEVUSUGlUMvosWfyMGGQKWupClw5ENNydG9y1KvaOI1UXCfwovhmQWV+Fe4 2kTxC2AeSMmb5vwxH6i/YTXIcjqrX+6vqtgtLAW6PzXLRe/NAKxGXOfKb3Zbqjx5LNNY07T5t YCcwH1dMn+etaypmV9kX86Y5LNQ9T9OB6UHmNYtSU1pDhkjRiwFC/0haQLZ7rejHnpqxN0j1p tEbiJfdCELqEcTDlsSfgrpdIiIwhCtfxX70Soo/bszkyywjGpnKEL7itWvg36d/UTkz6P7yRp h95PtzIUyKWLYEXxyO/ERhGbkMyxoVBpX1dbQXhRdyfk/1E8gjDkGqdGZPYwujnlpHZRSzpiE WlC8drHeeHAPIvFgqidd9+tQGZU8rNW0hjt3f0NsLje6WfNl8lP0nCXmYVRNsV2Abfrsyw79b 1AhNnM+lYO4K6Cx7Mx2I9c3xaOYs+C5JAih0wcuoj1FLuXX5w3X5jSfs8IU/UyyHb3wcvLREo ZkFlWtUe46pM1vTRvObw3HmMujjhaFQUOm+8PEUqBvq5pZ60X/Xw0ofWnLiN/BHepZCEFNaFv rtJ2WWReharIt15R/ezd6H07VD/BTA/6d2ZqG1aSemnBbSmWzQK30xVPM42JI12JKDM6PTZWa YGKaW4mcYAyI3+PlGzBkF25csKE3f0gHKW37o+IGCDc8xpS5iCLsoaK+sIRS5CnF/wb8NYFh X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.78 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230834 Archived-At: --=-=-= Content-Type: text/plain Stefan, we also wanted to say something more about side effects. Since the restoration of the pcase docstring this is completely missing. Maybe you also can take care about this? I would suggest maybe something like this: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-WIP-pcase-pattern-side-effects.patch >From 499e715e2f31fc7f9e50dfb553532aedaba1dd3f Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Sun, 28 Oct 2018 23:30:49 +0100 Subject: [PATCH] WIP: pcase pattern side effects --- lisp/emacs-lisp/pcase.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el index 57c2d6c3cb..ff59d2c3a0 100644 --- a/lisp/emacs-lisp/pcase.el +++ b/lisp/emacs-lisp/pcase.el @@ -139,6 +139,9 @@ pcase (F ARG1 .. ARGn) call F with ARG1..ARGn and EXPVAL as n+1'th argument +Evaluating a FUN, BOOLEXP or EXPR as described above should not have +any side effects. + FUN, BOOLEXP, EXPR, and subsequent PAT can refer to variables bound earlier in the pattern by a SYMBOL pattern. -- 2.19.1 --=-=-= Content-Type: text/plain Thanks, Michael. --=-=-=--