From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: map-put! and (setf (map-elt ...) ..) on lists Date: Sun, 16 Dec 2018 09:32:09 -0700 Message-ID: <87y38p4ely.fsf@tromey.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1544977898 31606 195.159.176.226 (16 Dec 2018 16:31:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Dec 2018 16:31:38 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) Cc: Nicolas Petton , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 16 17:31:34 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYZKI-000862-0n for ged-emacs-devel@m.gmane.org; Sun, 16 Dec 2018 17:31:34 +0100 Original-Received: from localhost ([::1]:42985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYZMO-0005BX-Q8 for ged-emacs-devel@m.gmane.org; Sun, 16 Dec 2018 11:33:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYZLG-000589-Uh for emacs-devel@gnu.org; Sun, 16 Dec 2018 11:32:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYZLA-00009k-F5 for emacs-devel@gnu.org; Sun, 16 Dec 2018 11:32:34 -0500 Original-Received: from gateway23.websitewelcome.com ([192.185.48.104]:47217) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gYZL8-0008LB-C8 for emacs-devel@gnu.org; Sun, 16 Dec 2018 11:32:26 -0500 Original-Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 243F637C7 for ; Sun, 16 Dec 2018 10:32:11 -0600 (CST) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id YZKsgZuQRiQerYZKsgfz1d; Sun, 16 Dec 2018 10:32:11 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YfAkBTgJluII15MmpV53L6z8W872AhVXtK+6yVJYE1A=; b=NLQJJxtx4x7c6VN+CDngRoWVKT Zntu6ixYlm/lc6CrK2KBD1vQmivTE6BvR8HKiqjpupx9c+741ZrOexSrElgZI70Kr3LvWPFn3MTMb kzHkWtvom4DOzOdsLgKf2LDQy; Original-Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:46162 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gYZKs-000KSd-Ib; Sun, 16 Dec 2018 10:32:10 -0600 X-Attribution: Tom In-Reply-To: (Stefan Monnier's message of "Fri, 14 Dec 2018 12:32:44 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.72.210 X-Source-L: No X-Exim-ID: 1gYZKs-000KSd-Ib X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-72-210.hlrn.qwest.net (bapiya) [75.166.72.210]:46162 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 192.185.48.104 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231854 Archived-At: >>>>> "Stefan" == Stefan Monnier writes: Stefan> -(cl-defgeneric map-put! (map key value) Stefan> +(cl-defgeneric map-put! (map key value &optional testfn) I wish Emacs would not adopt the Scheme "!" convention. I find it very distracting when reading code, as if it is shouting all the time. Also, IMO, it's not normally the case that modifications are so important that they have to be called out; and anyway if they are, it would be better to leave this to person reading the code rather than the person writing it. Tom