From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Apropos 54f297904e0c: Temporarily comment out CC Mode from tests which are incompatible with it. Date: Fri, 18 Jan 2019 23:47:25 +0100 Message-ID: <87y37hwpky.fsf@gmx.de> References: <20190117164350.GA18314@ACM> <20190118175437.GA4095@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1547851603 19276 195.159.176.226 (18 Jan 2019 22:46:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Jan 2019 22:46:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , emacs-devel To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 18 23:46:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkcuK-0004uq-Kw for ged-emacs-devel@m.gmane.org; Fri, 18 Jan 2019 23:46:36 +0100 Original-Received: from localhost ([127.0.0.1]:48424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkcwR-0002Nc-OE for ged-emacs-devel@m.gmane.org; Fri, 18 Jan 2019 17:48:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkcvL-0002NC-NH for emacs-devel@gnu.org; Fri, 18 Jan 2019 17:47:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkcvJ-00026y-I9 for emacs-devel@gnu.org; Fri, 18 Jan 2019 17:47:39 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:40419) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkcvI-0001eC-HY for emacs-devel@gnu.org; Fri, 18 Jan 2019 17:47:37 -0500 Original-Received: from detlef.gmx.de ([212.86.43.239]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MWT8s-1ghpbQ14pO-00XcFK; Fri, 18 Jan 2019 23:47:26 +0100 In-Reply-To: <20190118175437.GA4095@ACM> (Alan Mackenzie's message of "Fri, 18 Jan 2019 17:54:37 +0000") X-Provags-ID: V03:K1:4kTqzNI35tHUv4oYzwrLySZX9AoQIO9a7GJAxHrrVvNv99Y+GXm BDh5TyhKniSeZBcYu++DS0Sk6kZTGRzKBl25+rGkoOQp0px1sL0cHZFz2Oh4fxNMwJIVa9a y4chvOpF3A1GdQ0lKiA06wS1GiQsjX+tjnC+8UCCHqYmdOYw3Nnnk+/NP5REQq3Fg/1SBTS yYqN4bHKNuOHsefmeWApw== X-UI-Out-Filterresults: notjunk:1;V03:K0:mDWiq/99P1c=:Euyc17gbfF7jy4IAenF8Ax dzhbEYn28cfoIY/ZdidzLsO68jkoMdxB5s1610rEwFK6ujKJFyojGE+cmjlN6elgeKdKv2QAC 530BV0H+pmai9sYD0oCRnI0T/RSpWhTorH4oIENOGIuOXeF0NFA0AqPZxSZooW+g0VLHJeFuc 9L0jpL43KjF/2nH/ctK7QD8W2OvFPi/nqT7HZV0/IxQLj3Z83kWhYwkBCLdLKf3N7N/3wUXYR 6yw0eIWkv7VTE39I5r2Nz5iDEFJH0WmhpI3BmKPhDE6gmq85wK2SEZuDXY+pfghiH1oY1SjVY OR8ZsO4LKwE3DMGUTkQNigD8l+fXV6d+Qb9eea3Ayt3nyIgHWmHW6mG9yF1mupMjmZBSfR8Xs P5DWI2K4r0v7P0sThAbS+EPkiNPBmXOItHnD90B1SufZoKAMEt7AnLtDai46lu4AoK+4vXqky dUywwayM+C3l0y3y2aM3Df2OzWNOdhpclvAVCKln9ZQxi+3CyezcZXTXyB9fINaIs1+GHNAAk j3bOYAykBweCBuhLGgkH8URtdOaD7DkL6GGWUAwFZzEWd/3UO+iynK1PKUY84Kjh47LjSEr4P x8maU0hpcjP9TsQVsKOvjqF/D1gp96vulGNGeqfdUSQGBR4XVsMlzTqaX+WnamJcFkYEYdfcH kUEE8i5FLXUgYEQ/TFJKJKHq6o4D8TblZIt+Kj725ORu7dphrVoZ8Uie8BMFY3a6WIONWwvic tXGehX4Ah7O3iksaZci6FKF9LbHXO5AqgLtZlO8Hx+UpNNUizPXppV8MSiKePY9cFv4XDhbz X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232463 Archived-At: Alan Mackenzie writes: > Hello, Jo=C3=A3o. Hi everybody, >> > > Temporarily comment out CC Mode from tests which are incompatible >> > > with it. > >> > That would leave lots of failed tests in make check. People have >> > already remarked on those failures, implicitly asking me to fix them. > >> Yes. But the correct fix was to revert the commit that broke >> the tests, not this volkswagenesque atrocity. > > The tests are now broken. They make assumptions about CC Mode's workings > which don't hold. Why can't we cooperate to fix them? Please do not comment out tests which are broken (I have no idea why). The proper way is to tag them as :unstable, as explained in test/README. By this, all of us won't see them when running "make check", and you could still run the tests on your local machine while fixing them. Once stabilized, remove the :unstable tag. Best regards, Michael.