From: Michael Albinus <michael.albinus@gmx.de>
To: Alan Mackenzie <acm@muc.de>
Cc: "João Távora" <joaotavora@gmail.com>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Apropos 54f297904e0c: Temporarily comment out CC Mode from tests which are incompatible with it.
Date: Fri, 18 Jan 2019 23:47:25 +0100 [thread overview]
Message-ID: <87y37hwpky.fsf@gmx.de> (raw)
In-Reply-To: <20190118175437.GA4095@ACM> (Alan Mackenzie's message of "Fri, 18 Jan 2019 17:54:37 +0000")
Alan Mackenzie <acm@muc.de> writes:
> Hello, João.
Hi everybody,
>> > > Temporarily comment out CC Mode from tests which are incompatible
>> > > with it.
>
>> > That would leave lots of failed tests in make check. People have
>> > already remarked on those failures, implicitly asking me to fix them.
>
>> Yes. But the correct fix was to revert the commit that broke
>> the tests, not this volkswagenesque atrocity.
>
> The tests are now broken. They make assumptions about CC Mode's workings
> which don't hold. Why can't we cooperate to fix them?
Please do not comment out tests which are broken (I have no idea
why). The proper way is to tag them as :unstable, as explained in
test/README. By this, all of us won't see them when running "make
check", and you could still run the tests on your local machine while
fixing them.
Once stabilized, remove the :unstable tag.
Best regards, Michael.
next prev parent reply other threads:[~2019-01-18 22:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 14:57 Apropos 54f297904e0c: Temporarily comment out CC Mode from tests which are incompatible with it João Távora
2019-01-17 16:43 ` Alan Mackenzie
2019-01-17 17:57 ` João Távora
2019-01-17 18:55 ` João Távora
2019-01-18 17:54 ` Alan Mackenzie
2019-01-18 19:55 ` João Távora
2019-01-18 22:53 ` Alan Mackenzie
2019-01-19 3:18 ` João Távora
2019-01-19 11:07 ` Alan Mackenzie
2019-01-19 13:52 ` João Távora
2019-01-19 17:45 ` Alan Mackenzie
2019-01-19 19:15 ` João Távora
2019-01-19 20:58 ` Alan Mackenzie
2019-01-19 23:18 ` João Távora
2019-01-21 18:04 ` Stefan Monnier
2019-01-21 20:45 ` Alan Mackenzie
2019-01-21 21:46 ` Stefan Monnier
2019-01-21 22:41 ` João Távora
2019-01-19 22:37 ` Drew Adams
2019-01-20 19:05 ` Richard Stallman
2019-01-20 21:18 ` João Távora
2019-01-21 20:59 ` Richard Stallman
2019-01-21 21:49 ` João Távora
2019-01-18 21:06 ` Stefan Monnier
2019-01-19 3:25 ` João Távora
2019-01-18 22:47 ` Michael Albinus [this message]
2019-01-19 20:18 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y37hwpky.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).