From: Tassilo Horn <tsdh@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Keeping replace-buffer-contents runtime in bounds
Date: Sun, 24 Feb 2019 11:11:51 +0100 [thread overview]
Message-ID: <87y365a42g.fsf@gnu.org> (raw)
In-Reply-To: <83imxil8h6.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 17 Feb 2019 17:50:45 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> In the end I settled for a maximum number of seconds one can define
>> by setting a new variable replace-buffer-contents-max-secs, so that
>> you can define what's still acceptable in the respective use-case.
>> (Actually, if you set that to 1.5 or so, it may still run for 2 or
>> more seconds because the EARLY_ABORT expression isn't tested at
>> regular intervals or rather it is, but the intervals don't take
>> equally long.)
>>
>> If that number of seconds is over, compareseq returns early and
>> replace-buffer-contents falls back to plain delete and insert.
>
> The gotcha about aborting after more than the time-out value should be
> mentioned in the doc string.
>
> Thanks for working on this. My only other comment is that maybe we
> should allow passing the time-out value via the function's arguments,
> not via a global variable. It seems to me the time-out will be used
> in more use cases than MAX-COSTS, and in any case treating these two
> differently API-wise sounds strangely inconsistent.
I've done that and landed it in master.
The downside of having the MAX-* arguments instead of global variables
is that now we have a json-pretty-print-max-secs global variable because
somewhere a user has to specify how long he is willing to wait. But I
guess the JSON scenario is pretty unique in the size and diffs of the
replaced text, so that's allright from my POV.
I also changed the return value of replace-buffer-contents so that now t
means the non-destructive replacement worked as advertised, and nil
means we fell back to delete-region and insert-buffer-substring. Using
t for success just seemed more natural for me.
Bye,
Tassilo
next prev parent reply other threads:[~2019-02-24 10:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 20:09 Keeping replace-buffer-contents runtime in bounds Tassilo Horn
2019-02-17 15:50 ` Eli Zaretskii
2019-02-17 18:26 ` Tassilo Horn
2019-02-17 18:59 ` Eli Zaretskii
2019-02-24 10:11 ` Tassilo Horn [this message]
2019-02-24 16:12 ` Eli Zaretskii
2019-02-24 20:13 ` Philipp Stephani
2019-02-25 6:28 ` Tassilo Horn
2019-02-25 20:16 ` Tassilo Horn
2019-02-25 21:03 ` Stefan Monnier
2019-02-26 6:51 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y365a42g.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).