From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Should diff.elisp.xfuncname match cl-lib macros? Date: Sun, 17 Mar 2019 15:22:58 +0000 Message-ID: <87y35dcyp9.fsf@tcd.ie> References: <87wol0qecg.fsf@tcd.ie> <87a7hug7ld.fsf@tcd.ie> <83imwiydnr.fsf@gnu.org> <87ftrmeb80.fsf@tcd.ie> <838sxexjay.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="267659"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 17 16:27:33 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5XhE-0017YL-Nx for ged-emacs-devel@m.gmane.org; Sun, 17 Mar 2019 16:27:32 +0100 Original-Received: from localhost ([127.0.0.1]:56825 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5XhD-0003Ia-KQ for ged-emacs-devel@m.gmane.org; Sun, 17 Mar 2019 11:27:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5Xfv-0003IJ-SO for emacs-devel@gnu.org; Sun, 17 Mar 2019 11:26:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5Xcs-0000et-TS for emacs-devel@gnu.org; Sun, 17 Mar 2019 11:23:03 -0400 Original-Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:34270) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5Xcs-0000eQ-G4 for emacs-devel@gnu.org; Sun, 17 Mar 2019 11:23:02 -0400 Original-Received: by mail-ed1-x52c.google.com with SMTP id a16so11438100edn.1 for ; Sun, 17 Mar 2019 08:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=W56cDtfLHxd7H1RthqHhngcBsVgo7rA7jqkkdyVdE2k=; b=ymG1Pw5VQ4xw68WCgiJZLn5z4Z5yHxX8lSTWSBkrDIVYTRkx8dn33gTyLQeLUi5EO4 tePe8P9iOsFtcouqbgoeFaomUp8agwd48XNzkfp0SYf3DiaR0ZI+0Qhltm31krIjj7dL Ns4BG7ejYRgWwuNKYq/G3kxgUwttx6I9AMv1F96cPxOYNjIftEj4dz7LMgqxzDYkft5b 3L5LnOPzZCe586Xb87vFrHhUxRwx34zNARBy284Cp8FODlS0s+/xjYR7V4TVC986zrXW a/apsR5wCPiUC+aveyqye78yLlPvGYFTHgKmYFJu8NtQ49pAhPm6D3Ww+GmFmUAsTQxS LKwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=W56cDtfLHxd7H1RthqHhngcBsVgo7rA7jqkkdyVdE2k=; b=HQ9eiqWFtuW9oCazSGS1Nt14aWUWT2b/l+JHaRSdw5DsgsCwURIIAY+8tZU51oxHPg QTGDif5zfkXBsN3QQjieFPCn3XnOL3rkWsQcWKZ79z8GMnOyzBA7CMyJJDor/h8lhQDx Zp5iF0vvXZF0h9PIPYzDg+fMGTYT0/SYV7wlu1CPMQh1SJBzil+WRum6O4taV5MwLr4v pd43J9nxYnwxb7I7I8qOZTLFAHumghG8YbN+ltPAZ68EOC2J3QsH2EbcCKdX4F6T+BT8 yd6skby76TWWaokr4XPFXY2y0ci/3vTMuN0LIfJEDSaDQ7Z5m0XGCl6+4ANeCd2bkTQq j0DA== X-Gm-Message-State: APjAAAWddAWh88jSBYqdsHwui1uNohXaV6PO5CrNuNaxSOv7Xzh7xP40 M+dXGIju6q6tB568KMiXLg5/nQ== X-Google-Smtp-Source: APXvYqzEOmtwTeLh4YiQ67JhXbxBnOgJRk1cNQ58Eg5zi1C+B7f/b8APVZnUOA1Nnbef9eKZaXLYXg== X-Received: by 2002:a17:906:4819:: with SMTP id w25mr8326248ejq.150.1552836180896; Sun, 17 Mar 2019 08:23:00 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id l22sm2622627edc.68.2019.03.17.08.22.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 17 Mar 2019 08:22:59 -0700 (PDT) In-Reply-To: <838sxexjay.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 17 Mar 2019 05:37:41 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234271 Archived-At: Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Cc: , >> Date: Sat, 16 Mar 2019 21:54:55 +0000 >> >> > So I think until we fix this basic deficiency, extending that to more >> > symbols will just add to the mess. YMMV. >> >> Which deficiency do you mean? That 'git log -L' picks up >> next-line-or-history-element instead of next-line in your example, >> i.e. that it's currently inaccurate? > > Yes. > >> How do you usually use this feature? > > With commands such as the one I show above. It's supposed to show the > history of changes in the named function, but instead it almost always > shows unrelated history. I'm not aware of any way around this other than through restricting the search regexp, as Andreas alluded to: git log -L ':next-line[^-]:lisp/simple.el' Are you? Either way, I'm not sure the proposed change to xfuncname will make 'git log -L' any harder to use in practice. On the contrary, it will allow using 'git log -L' to search for cl-defuns, etc., where this is currently not possible. -- Basil