From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: Increase minimum required GTK versions? Date: Fri, 12 Apr 2019 13:33:31 -0600 Message-ID: <87y34fuigk.fsf@gmail.com> References: <87h8b9tz84.fsf@gmail.com> <83h8b98wg3.fsf@gnu.org> <87d0lxty7f.fsf@gmail.com> <537036b7-549c-0aab-cc06-70c26c683ac7@cs.ucla.edu> <87y34kiloy.fsf@gmail.com> <87o95f141i.fsf@gmail.com> <838swj6nuk.fsf@gnu.org> <87h8b61rid.fsf@gmail.com> <83sgup6ef8.fsf@gnu.org> <87tvf5tm4f.fsf@gmail.com> <83r2a7kqi6.fsf@gnu.org> <8736mnvybp.fsf@gmail.com> <83o95bkpcl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="48411"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 12 21:34:17 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hF1wH-000CPx-4E for ged-emacs-devel@m.gmane.org; Fri, 12 Apr 2019 21:34:17 +0200 Original-Received: from localhost ([127.0.0.1]:41721 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF1wG-0005X9-5A for ged-emacs-devel@m.gmane.org; Fri, 12 Apr 2019 15:34:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF1vb-0005VO-4n for emacs-devel@gnu.org; Fri, 12 Apr 2019 15:33:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hF1va-0006Kw-5K for emacs-devel@gnu.org; Fri, 12 Apr 2019 15:33:35 -0400 Original-Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:41337) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hF1vZ-0006KD-R6; Fri, 12 Apr 2019 15:33:34 -0400 Original-Received: by mail-pf1-x42a.google.com with SMTP id 188so5599912pfd.8; Fri, 12 Apr 2019 12:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vXN/lunQPkNC5OsUqa/lSajlbqGfqo6mQrWw6rgiKxw=; b=aYD5qWDwQNSo07/aNecTmHZ0HaktJFNw8ndKbkP8A2Qn3lHtJe4aiErqjheYz9y/sG LvxjC+unDl97VItj+EQmeHHrOztSYljViYqbnN6RvLIwI/hrRrFK8A8Tf/848Kxv/HLP lem8LWEaVB09L6jTzMupSOaU76x1jwKhTRHmJK8NUx3644+HRSAETfy8ywjMFdFI2QK+ xQQGyI4+bzVNXUJ1k8fIYTmvuP1VjTXqX+E+MYwItGM4ZUVEDxCx3/9O8p/Okvzl0Ipj 4120301oYixqSpWuA4/wxx+Y7OnIq4hsFsOiI8n1cwdpKzZtChDJyNbd5IT0nYlaCWak ck/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vXN/lunQPkNC5OsUqa/lSajlbqGfqo6mQrWw6rgiKxw=; b=MotyZwhtj0fgKcztdD+Bikd6gsVBQF8Zn28MJwCTScFXEUZK36PnGU4t0LoQDctqrO k+boT7dgO73Un8+9SNqLx1nUX4N67c+RzPTsKjHLp7hH0u4x5JPks68ZmlNWkDooFa2Q JyU0B0e5NgPgWqjQUBhBuXwb67Zgna3NV7185eYXGJZfqUAJRHq1guCdCPCl8ywEzLBT PbveBNTMIjg3f+o5vKRDdABtKwOJFVLMsib0KOgLnjY5J/z6PHSAaEK8PE09LXolnaER XwR7o53Qz2SN6Vu2/YBbm67QiXWtOO8L0cnXv27iOEGxD073K5zB/G3YXCF2IpXNauL4 KN5g== X-Gm-Message-State: APjAAAVQOYOwP6mEuXc9Yof5XKzlps7VihfD1wuJaiOWjhvBHVjyLJFY 2+1Yo/aNsR/yVrv+SySy7p+Ronkd X-Google-Smtp-Source: APXvYqxPjGsqT4X+5fBVg4CwQCmiLimKeUbi7lBs1GAPU91JrWf8bmc1oaqX1QEtGuYZy9v5bC42sA== X-Received: by 2002:aa7:92c4:: with SMTP id k4mr59036231pfa.183.1555097611754; Fri, 12 Apr 2019 12:33:31 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id p6sm44210678pfd.122.2019.04.12.12.33.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 12:33:30 -0700 (PDT) In-Reply-To: <83o95bkpcl.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Apr 2019 22:14:50 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235366 Archived-At: Eli Zaretskii writes: >> From: Alex Gramiak >> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org >> Date: Fri, 12 Apr 2019 13:05:30 -0600 >> >> > Are you sure? I still see the code related to this being removed. >> >> That's part of the simplification of the code. Before it uses a >> predicate procedure to check the value of x_gtk_use_old_file_dialog, >> which I removed in favour of checking the variable directly. It also >> used function pointers to wrapper procedures to get the filename, which >> I removed in favour of calling the gtk procedures directly. The actual >> old file dialog (xg_get_file_with_selection) is, in this patch, still >> present. I tested again with GTK 2.24 and GTK 3.10 and it worked as >> expected. > > Please don't simplify that part, but instead leave it alone. Why, especially since the reason for the complexity was because of supporting an older (older than the current minimum) GTK version? I don't believe that the code is so fragile that it has to be left alone. > Why was the configure-time test related to that removed? That test was for versions pre-2.4 that did not support the old file dialog; there's no use for it now. See commit 572a3cc2664adea7b5a3303b04b57fe1ba5b4641 for the introduction of the test. > Please also don't obsolete the variable, I see no reason to do that. Why not, since it's part of an obsolete (in GTK 2) and removed (in GTK 3) GTK interface? This seems like the time to obsolete such a variable. IMO it would do well to obsolete it at least for (version<= "3" gtk-version-string) since it does nothing there.