From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [RFE] Migration to gitlab Date: Sat, 11 May 2019 20:25:00 +0100 Message-ID: <87y33cx08j.fsf@tcd.ie> References: <87imwhmmt8.fsf@gmail.com> <87y347g1l3.fsf@iotcl.com> <9ac21e82-8e47-f9b5-f88d-23c0c56946d1@yandex.ru> <87pnpc1lby.fsf@iotcl.com> <83zhoezdqc.fsf@gnu.org> <87imuivfcr.fsf@iotcl.com> <83k1eyfxls.fsf@gnu.org> <17D21056-10B2-4813-AE90-9B2706936CE9@icloud.com> <83imuifqjc.fsf@gnu.org> <87lfzehrug.fsf@gmail.com> <20190511021206.GA4049@ACM> <83ef55eapl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="4688"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, =?utf-8?B?7KGw7ISx67mI?= , dgutov@yandex.ru, acm@muc.de, toon@iotcl.com, agrambot@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 11 21:26:07 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPXdG-0000z8-CJ for ged-emacs-devel@m.gmane.org; Sat, 11 May 2019 21:26:06 +0200 Original-Received: from localhost ([127.0.0.1]:34495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPXdF-0006NC-9G for ged-emacs-devel@m.gmane.org; Sat, 11 May 2019 15:26:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPXcM-0006M4-Ss for emacs-devel@gnu.org; Sat, 11 May 2019 15:25:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPXcF-0005Kz-UG for emacs-devel@gnu.org; Sat, 11 May 2019 15:25:05 -0400 Original-Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:39995) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPXcF-0005K7-Jm for emacs-devel@gnu.org; Sat, 11 May 2019 15:25:03 -0400 Original-Received: by mail-ed1-x544.google.com with SMTP id j12so9791734eds.7 for ; Sat, 11 May 2019 12:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=XJN0FHP2hKU6JShOcxykgq8oo7WWGkgvJ6jJpKaTRLs=; b=DmW4btjNwOb68Miu5qboQxE17WK+1hLp3Et4RqCHvqLTd5AjeS7E3f0XD00xOtRO45 UZF1QVuwT6mlghl8gP0jqDeWVXJhXXexx45wfZUn1njgG7HXADj6RVyVtPGTd6AB7ZQm VZL7piWnFLDzqW2nL5Q+wOiiERB4N6la8w4mkTYg7Qb4xOzTcxWnOvXkGLfuZ9K68Fs2 ruKnoVnJJ0Qc6nmHYVETsmWAKCohzFDJGmdNVgL8yIvazy7f4wt40mrUR3wmjyitDB4y gB01sFf73hSTh4S9Qt06xbx8CDrzVVV+/OGSCVLsyeNjJjF7mvdqcXV/+ivl/P9fwcFG OIuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=XJN0FHP2hKU6JShOcxykgq8oo7WWGkgvJ6jJpKaTRLs=; b=cwPpYgbSWOiMGB2uczeeLBPuCDkM5uX+WTJJDT/Js1TAmL2mia8WF3VsymQyE64DSY WbgqMboWRFF+QbUF1XngMMmnl5rvtIKuIbGFyUXwHFMNJByW3/v9AY1NI8gUyLyKorOZ Mr+gX8pHx7NGFIT8uJwULFhzii3ozMMVcE9TIcRWMjd/9GYrI9DY014YrIoqVvIFk+mP r4DGYOwRfES4pAI3+APHRKRfiAItsmZQJc1lxSSiIogtpE8Tf497OPKasfdZu+NZX7Xm I5dx6xlm0k8zHMFXBxwQ3TzB8QuFh7Iic9AG0vdQkp2D+BHpV+xJ9MZQc+vm3L9Eg4KY X3WQ== X-Gm-Message-State: APjAAAVOl32NtnhIgJVtgBrDMZ2gZB7rxKm55DUCVunKpzI2Ppk6NXz8 W6DFrau57BIcguNyR4pMQibjng== X-Google-Smtp-Source: APXvYqy5VLg/Ui4+OWfdYAVTCZ9vcHV8Y+EL4NYgIbWbLixmtTRf6I18RafCNizRlR9NffYmTrmlMg== X-Received: by 2002:a17:906:ef1:: with SMTP id x17mr14711575eji.15.1557602702601; Sat, 11 May 2019 12:25:02 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id r20sm2431926edx.46.2019.05.11.12.25.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 11 May 2019 12:25:02 -0700 (PDT) In-Reply-To: <83ef55eapl.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 11 May 2019 10:01:26 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::544 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236441 Archived-At: Eli Zaretskii writes: >> From: =EC=A1=B0=EC=84=B1=EB=B9=88 >> Date: Sat, 11 May 2019 12:47:27 +0900 >> Cc: Alex Gramiak , Eli Zaretskii , >> emacs-devel@gnu.org, toon@iotcl.com, monnier@iro.umontreal.ca, >> dgutov@yandex.ru >>=20 >> So the outsider can =E2=80=98fork=E2=80=99 the repo, to make an exact cl= one of it, >> push his/her changes(commits) to GitLab, and make a merge >> request. The pull/merge request is a request the core contributor to >> =E2=80=98pull=E2=80=99 the changes of the forked repo and =E2=80=98merge= =E2=80=99 it just as if the >> forked repo is just another branch. This can be done by just >> clicking a button to merge(in the web UI). > > Does "clicking a button" take care of various minor details I > frequently need to do when applying patches from random contributors, > such as fixing the log messages (or providing them in the first > place), adding a reference to the bug/issue, adding the > Copyright-paperwork-exempt tag, etc.? No, but as I mentioned in my other message, you needn't use the button, and can cause merge requests to be closed by pushing the relevant changes to the target branch; GitLab then knows that the merge request was merged. I think the way it knows this is by checking that the commits comprising the merge request are contained in the target branch. This means that any edits made to the commits outside of the merge request may confuse GitLab, as the commit hashes will have changed (as Dmitry mentions elsewhere). In this case I think you need to either close the merge request manually by clicking a button, or include an automatically stripped "quick action" command such as "/close" in a comment to the merge request, or make sure one of the merge request's commits include a similar command such as "closes #123". >> When the core contributor decides that the PR is done and merges it to t= he main repo, GitLab automatically >> closes the issue. (If the PR was found to be an incomplete solution, the= issue can be re-opened.) > > We currently have the opposite situation: pushing a fix doesn't > automatically close the issue. Both are bad as defaults, because IME > what needs to be done is split roughly 50%. So a much better UI would > be to force the user to check a box when "clicking the merge button". Given my description above, I think (in the case of GitLab) this would be similar to the current requirement of including the bug number in log messages, though its purpose would also be administrative, not just for posterity. Thanks, --=20 Basil