From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master fe939b3 1/2: Fix reference to `tags-loop-continue' in doc string Date: Sun, 04 Aug 2019 14:09:06 +0200 Message-ID: <87y3099lp9.fsf@mouse.gnus.org> References: <20190801195403.16246.49802@vcs0.savannah.gnu.org> <20190801195406.087AF20CC8@vcs0.savannah.gnu.org> <87ef23allc.fsf@mouse.gnus.org> <877e7vpgmt.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="203297"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 04 14:09:18 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huFKA-000qnT-9e for ged-emacs-devel@m.gmane.org; Sun, 04 Aug 2019 14:09:18 +0200 Original-Received: from localhost ([::1]:44270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huFK9-0000PZ-BM for ged-emacs-devel@m.gmane.org; Sun, 04 Aug 2019 08:09:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41863) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huFK4-0000PG-BN for emacs-devel@gnu.org; Sun, 04 Aug 2019 08:09:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huFK3-00089c-Fp for emacs-devel@gnu.org; Sun, 04 Aug 2019 08:09:12 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:59200) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1huFK3-00088L-9b for emacs-devel@gnu.org; Sun, 04 Aug 2019 08:09:11 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huFJz-0007Ab-JS for emacs-devel@gnu.org; Sun, 04 Aug 2019 14:09:09 +0200 In-Reply-To: (Robert Pluim's message of "Sun, 04 Aug 2019 14:03:24 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239163 Archived-At: Robert Pluim writes: > >> +(eval-when-compile (declare-function fileloop-continue "fileloop"= ())) > > Lars> I don't think this is necessary -- you can just have the > Lars> `declare-function' without any `eval-when-compile'. But you sh= ould > Lars> probably include the arg list? > > I did :-) > > fileloop.el: > > (defun fileloop-continue () Oops. I thought I checked. > It begs the question why xrefs replaced a 'do the next thing' type > binding with a 'go back' type binding in the first place. I=CA=BCm tempted > to say that xref-pop-marker-stack should use a different binding, and > M-, should be fileloop-continue, but the xref one has existed for 5 > years now. Yeah, I think it's too late to make xref-pop-marker-stack go to a different binding. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no