From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master adfcc17: * lisp/vc/vc-dir.el: Commands to mark un/registered files (bug#34949) Date: Mon, 06 Apr 2020 01:50:32 +0300 Organization: LINKOV.NET Message-ID: <87y2r9wnrb.fsf@mail.linkov.net> References: <20200402220815.6555.35405@vcs0.savannah.gnu.org> <20200402220817.0DD6F20CDD@vcs0.savannah.gnu.org> <6f68379d-225d-e3bd-ef22-8e307eacdeb4@yandex.ru> <874ktybzss.fsf@mail.linkov.net> <52a199f7-919f-4dd0-8c94-25e6b0cf7ea5@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="89134"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org, Stefan Monnier , Dmitry Gutov To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 06 01:36:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLEoS-000N6X-Nd for ged-emacs-devel@m.gmane-mx.org; Mon, 06 Apr 2020 01:36:24 +0200 Original-Received: from localhost ([::1]:52754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLEoR-0001lw-Pd for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Apr 2020 19:36:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39100) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLEnz-0001Li-4c for emacs-devel@gnu.org; Sun, 05 Apr 2020 19:35:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLEnx-0005jk-No for emacs-devel@gnu.org; Sun, 05 Apr 2020 19:35:54 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:40829) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLEnx-0005jJ-IQ for emacs-devel@gnu.org; Sun, 05 Apr 2020 19:35:53 -0400 X-Originating-IP: 91.129.99.85 Original-Received: from mail.gandi.net (m91-129-99-85.cust.tele2.ee [91.129.99.85]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 5DCFCFF802; Sun, 5 Apr 2020 23:35:48 +0000 (UTC) In-Reply-To: <52a199f7-919f-4dd0-8c94-25e6b0cf7ea5@default> (Drew Adams's message of "Sat, 4 Apr 2020 17:51:53 -0700 (PDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.199 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246497 Archived-At: > I gave reasons for not conflicting with Dired bindings, > if VC Dired is derived from Dired, and especially if > such bindings make sense also for VC Dired. > > But there can be other, opposing reasons to repurpose > a given Dired binding, again especially if the Dired > binding is not so useful in VC Dired. > > There's no hard and fast rule, IMO. Such things are > judgment calls, after weighing pros & cons. It's you > who should decide what to do here, for VC Dired. Ok, then I'd leave this to Dmitry to decide what to do here, because currently I'm already completely satisfied with the new keybinding for marking registered files that was too cumbersome to do earlier when it required marking separately each of file types (added, removed, edited :)