From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: master c59e878: Inhibit modification hooks when saving eieio-persistent's Date: Sat, 02 May 2020 00:24:16 +0200 Message-ID: <87y2qb9tv3.fsf@web.de> References: <20200501192115.23847.67499@vcs0.savannah.gnu.org> <20200501192116.A55EE20B5B@vcs0.savannah.gnu.org> <87368jba7f.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="79823"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 02 00:29:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUe9a-000Kez-SI for ged-emacs-devel@m.gmane-mx.org; Sat, 02 May 2020 00:29:06 +0200 Original-Received: from localhost ([::1]:47854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUe9Z-0004K6-Nh for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 18:29:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUe6i-0002Pg-Nl for emacs-devel@gnu.org; Fri, 01 May 2020 18:26:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUe51-0008VD-7R for emacs-devel@gnu.org; Fri, 01 May 2020 18:26:08 -0400 Original-Received: from mout.web.de ([212.227.17.11]:56319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUe50-0008PP-Hh for emacs-devel@gnu.org; Fri, 01 May 2020 18:24:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1588371857; bh=MKilY5MySFreSMEAn/Wr+yJtZt8hwMBBl5iJUdkdKxI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=IUjkj/5Q7X4e+80+cDTQ5/eNPz8CSjJzgBEvU5hm7jixoSldo1W7HMH6uyEHxdBIt DcN+lgDygTmEVesBo3PALeFEWHITmJBN9VcycgEGhH+2wvOYwpaY/Oh0QgXxtLMgEJ 8ntmHxLlW4sz0379X1J+h+APMlfr+mxxsMms2J9c= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([188.99.168.6]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MGzba-1jQmSx2nZ4-00DnU4; Sat, 02 May 2020 00:24:17 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 01 May 2020 18:03:05 -0400") X-Provags-ID: V03:K1:adhlW9CIXQZOUgGB9/xF/Rz3480GXLdXlwh+j37t1LarEvaUXMU 21W13+TpoeDBLuZbbfJz9bvF9QzWYyLP5/SWPA/dqVqEXOzGlc1RXKlu2MEe+HDuQcC/AyC CjnzB3SJHNlmry1I/KmbBTUWQ9PeOUCRfLfnQk4OEPaPTKMIl+bXxmGZnW2t+hQnDqpy78R cSJcVkXUyZDeGOU2/layQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:1G6EDLjrC1w=:3xD+aVYUf4WHhAv0kBc9x8 MUaURyZlFL053Sjut/JjUwerujSfetmZ1TqrJ/2EktP7+WWHOeeVI/8Ycc5/tjP2NaPSuATe0 PBmdKE2nNWmM8U3AYJWEvWpG14bJaLASR/bbrIpT3C44JBzplDfBgSZk9c3mjiFa+4zYL9ijx dCZTZh5FsauINbUaodoF+Pc+VbtHAeZIEABQorOpWki3UWrp7vUtqMTszYchcLmsaRez0XmSm 6Cn8rkfx7PSFh/z/DIWNPUhI9hkhijMZn7NPuZu/hxhmIfgYV4DhdMxJISQNCRy3FCzfj3T3s j1InJscbZSDs2us+dAeJkStyZDayh0Ey0kP20V6RHjI3ma1OUl3VlBZ7q6UKF4OehK4EAKpRU SXveFxAvaWuGDAP+SXnSmrgS8dAgdX4K7TuTmz5CNfQoKpAumWkIKPCFJEVkQKnSSym9/LtKa PLSgToxna6GkH9r/B1WGQWi0h/xsP9YlX2zaw35m06/0c0miqcfiKzBYgw27xsgciYm4T+h+P h0z/lGq9D/10I7J9Y9sPjJs6zK27Nc0xNGFevMEdu6UpFOpaEiEYXdvET5T5uX9Pc9MpbKd31 6JyRi53oTthL3B7rNt2xVa6475YQB7ByAKk0RhfCtwwzq5dAiKcIYC41VJuvqtbEjcIZQPQ3d J+3NR7dPCKX3ibuo5ZizIi27NABaRkPEFnWEyaE0CV1OKY7f5OF+L0jL+1QpgbqTgV/m0k0iJ mg34zD0b6kiIwDkfl+QLYIxcqS4Gd/w5lZEuaAL49S4Lp6JNR3/uA8TDt5IMCIGZ7yM/KB/R Received-SPF: pass client-ip=212.227.17.11; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/01 18:24:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.11 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248347 Archived-At: Stefan Monnier writes: > What kind of speed up have you noticed? A factor of roughly 4. > Have you profiled it to see which change-functions slow us down I tried, but no, with "profiler" I only saw 80 % of time wasted somewhere, but no samples where assigned to anything. That's why it took an hour until I found that change functions are the culprit. Note that they are typically run 10000 or 10000 times or so. I don't want to conceal that I have on-screen.el making use of after-change hooks - but I dunno what other people might have put there. Having such stuff in such a low-level operation is rather useless, and I don't know what modes people are using are putting into after-change hooks. > (maybe we can disable them some other way, such as by using another > major mode)? Other than `fundamental-mode'? > Have you tried to use `combine-change-calls`? No, but that's something I can try, yes. Actually, `object-write' would be the better place to use this, but since `combine-change-calls` needs to know a region, and `object-write' is agnostic about where it writes to, this doesn't seem to be possible. Or should I just test `standard-output'? I guess it doesn't make sense to call after-change-functions for every single atomic operation of `object-write'. Thanks, Michael.