From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master f51f963: Fix some side-effecting uses of make-text-button Date: Fri, 05 Jun 2020 16:48:05 +0100 Message-ID: <87y2p1ecp6.fsf@tcd.ie> References: <20200604223056.17078.81265@vcs0.savannah.gnu.org> <20200604223058.1850020A26@vcs0.savannah.gnu.org> <87eeqtiy4x.fsf@tcd.ie> <87img51y04.fsf@gmail.com> <87tuzpmxii.fsf@tcd.ie> <871rmt1t4g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="29513"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 05 17:49:38 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhEbC-0007bc-Gk for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 17:49:38 +0200 Original-Received: from localhost ([::1]:46190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhEbB-0003Ha-F9 for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 11:49:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhEZo-0001ui-2Y for emacs-devel@gnu.org; Fri, 05 Jun 2020 11:48:14 -0400 Original-Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:36120) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhEZm-0004CT-Mr for emacs-devel@gnu.org; Fri, 05 Jun 2020 11:48:11 -0400 Original-Received: by mail-wr1-x434.google.com with SMTP id q11so10264277wrp.3 for ; Fri, 05 Jun 2020 08:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=LioDA5bJ3c86e+Pl2x6ovbtJ1Ee/fWVFre/u3T3vVsE=; b=B0u2H9MB3UhXAdZaKoJi2XuiuVAPuw9wEXnAiReeaFWkMZqbbdTICi3vOvmCAJrdoU djX4HG/rZcgChhgZP65B7KNHP/CrXQshdbbNF6sWdho64yQvr7ykp5hHtfoYWUZv5Ls6 hoZY0EJy2IswMVZU/TsjuTWCSSVC2kBdBQKwwZVnHBdHfKsGtsoNQVDmSFkIG7ZH1t9/ aYHQAoDn3XhfY2AiynH7WGeXuL/rtX7qc4f+ogJKKmqN8r2PDOavTBpgbmpRTtBP4rCJ c3nCtiiqQ9ZKOLHNkWnR4r0EwD7Lg2NleOUAp92yEA8hKK5qN3AXtKTHmUWkbOlol919 n+ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=LioDA5bJ3c86e+Pl2x6ovbtJ1Ee/fWVFre/u3T3vVsE=; b=NC25XiNfcASe3107YNwmdovD2LF9A6vQRvdxd4jAsO37/AInsKQd3LCy4ZXwUvbh1C /CvrIPt/yKaSzS7tt1yZcxboaw0WMri6eybt2vpiHLJfXLEsYwnQyssDTk/zAghMpouN 7vYKaWcRaewyZzRAikP0PxCXmcZ2CiJSqx+cR0V8+igCSgvMwFlF2SBkbx/9OTCLlr+X 4tsglkR0v1r2uVnU04dvAoi7PdUqX6cKhGmTet2QVCXQqDdHNAdq94x42twUMj9mtIid C3lH6kVVB03PHzcod8gkTPdAzDeFf6ZhpUELDSkns4sWa3QnOomC2VRRMRFQAmogOywj QsMw== X-Gm-Message-State: AOAM533Y96jKnpvlRgf+CHbPMojcARynf20hXy1nl8jMZ8HU01gRV3sj UFkEPFdzHfe3/CKyUeKXEKrFuA== X-Google-Smtp-Source: ABdhPJxwiYQXXDUEeHtbmsLbxLXOu8XHctSVgAajb+tJIIv7YVzOyDDXwxj3Wxwxdz4YbQmQoAuUgQ== X-Received: by 2002:adf:a50e:: with SMTP id i14mr10271196wrb.21.1591372087497; Fri, 05 Jun 2020 08:48:07 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id q5sm12740836wrm.62.2020.06.05.08.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 08:48:06 -0700 (PDT) In-Reply-To: <871rmt1t4g.fsf@gmail.com> (Pip Cet's message of "Fri, 05 Jun 2020 14:31:43 +0000") Received-SPF: none client-ip=2a00:1450:4864:20::434; envelope-from=contovob@tcd.ie; helo=mail-wr1-x434.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251908 Archived-At: Pip Cet writes: > "Basil L. Contovounesios" writes: > >> Pip Cet writes: >> >> [...] >> >>> It would not be a quick bug fix for code that uses (propertize "string" >>> 'a 'b). >> >> propertize returns a copy of its argument, so it's not problematic in >> this context. > > Thanks for pointing that out. I hope it was still clear what I meant. It rarely isn't. :) >> My only concern with destructively modifying string literals as in the >> (make-text-button "here" ...) example is that it can "pollute" that >> string literal for all of its users, which is both "rude" and >> unnecessary in this case. I simply find it cleaner, less intrusive, and >> less surprising to modify only one's own copy of a string in such a >> trivial case. I'm not personally concerned with crashes, theoretical >> purity or mutability, or anything like that; for that I defer to you, >> Paul, and other experts. > > I'd like to apologise. I made several mistakes in that email (including > using the word "off-handedly" when a less offensive term would have > done). Most importantly, I think, I was commenting on a change that, as > you correctly point out, made the code cleaner and less surprising, as > though it were a whole-hearted endorsement of breaking any existing code > that is more surprising or less clean. I see now that you said no such > thing. No need to apologise. I figured what you meant, don't take offence, sympathise with your position, and am interested to follow this discussion. I just wanted to establish that this particular commit should=E2=84=A2 be pretty uncontroversial, which I hope I succeeded in doin= g. ;) --=20 Basil