From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: RFC: Automatic setup for bug-reference-mode Date: Sun, 14 Jun 2020 19:08:07 +0100 Message-ID: <87y2optta0.fsf@tcd.ie> References: <87r1uihtsu.fsf@gnu.org> <87h7vd3cbs.fsf@gnu.org> <87tuzdsj8d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="100164"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 14 20:08:46 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkX3m-000PzE-MA for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Jun 2020 20:08:46 +0200 Original-Received: from localhost ([::1]:42584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkX3l-0007y0-Ms for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Jun 2020 14:08:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkX3F-0007Z9-BE for emacs-devel@gnu.org; Sun, 14 Jun 2020 14:08:13 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:40571) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkX3D-000530-FC for emacs-devel@gnu.org; Sun, 14 Jun 2020 14:08:13 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id h5so14828855wrc.7 for ; Sun, 14 Jun 2020 11:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KEQYaH6zb6xV9IYgZGjO6THsvm9eZ5wQRvxNaOVBdK4=; b=CK/fqxD57GUPWUVTS+nhM9LRVLMspdYZwAf30EZdkOxuT55kzB5/XumJjj/5FvB8+r RQ219GPevAInTVJ2u2AJIUsx8VefxY4Cw4G3DsomWGiuzoZB7Moo15ly2o71lSshJGUD Vch4JMT1Kovj3gXtgC9fMBSE0MmPWsegyDDWi06S2dWpcVqMWoQCfS72hPCrWrbWRAwU /cDRHtyrJRvCdck+JvEu0bZdmc1gICxirLbrCjFBW3jiX/wc5e95CqVUeMoT8qTMlTft eDtpVHgPjKKnYizZvY0WYcn8x6aXpNL6gz0ip+jrOgsLeVKsy+EJEjLkYJiIlxqcYp5I MAsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KEQYaH6zb6xV9IYgZGjO6THsvm9eZ5wQRvxNaOVBdK4=; b=Plcf4sTSPMrd05akB29lNMDusZ7gc0qHY88rpzDMZOjxKj9eQjeF3b0G89f12WfXtq TEj/06cxHMESfBBlpQVKj4hyqFG4TTscILVib8tLSJb/zcjz7H992H02Qe28mzGSgH7t +fMpMoDiMPooogk1NHFK6xQkpUVXmJskymEbAgsZXctFzGkaOJNLLVDHFViKeqmR4m5t eScC9qruCQe+5qot+98guZQtY1tR8HuGg1Ah9+yG7VDN4HjScivuGMnWS93sTlphHilR d9Uun9eAmoOW2mkUmck2Fp+ZtGtMxvxrWOI9rpkOSuSNvFtKaFySqdOsGCtuacHv8Ner bANw== X-Gm-Message-State: AOAM533c3cnAWAnA2UjdTPRataBTTJBUXrDHKGFjSxQnvCAucNbe/3CX uh47mJgsyF2zqL2cCnYeoDZ54UnwHts= X-Google-Smtp-Source: ABdhPJxxSmtNRylEEIFf+/0sJHw3E8U1bWMWmA8YRan9G/nnjEzDxY2fiiGJ2wJtAWCJmId9DEoy8Q== X-Received: by 2002:a5d:500d:: with SMTP id e13mr26653989wrt.150.1592158089388; Sun, 14 Jun 2020 11:08:09 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id o15sm18750195wmm.31.2020.06.14.11.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2020 11:08:08 -0700 (PDT) In-Reply-To: <87tuzdsj8d.fsf@gnu.org> (Tassilo Horn's message of "Sun, 14 Jun 2020 18:30:26 +0200") Received-SPF: none client-ip=2a00:1450:4864:20::431; envelope-from=contovob@tcd.ie; helo=mail-wr1-x431.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252242 Archived-At: Tassilo Horn writes: > Looks right? I can only comment on one thing: > +(defun vc-bzr-repository-url (file-or-dir) > + (let ((default-directory (vc-bzr-root file-or-dir))) > + (with-temp-buffer > + (vc-bzr-command "info" (current-buffer) nil nil) > + (goto-char (point-min)) > + (when (re-search-forward "parent branch: \\(.*\\)$") Doesn't this need a non-nil NOERROR arg? > + (match-string 1))))) > + Thanks, -- Basil