From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: ai_flags in calls to getaddrinfo, broader call for reproducibility check Date: Tue, 12 Jan 2021 16:36:41 +0100 Message-ID: <87y2gyyxo6.fsf@gmail.com> References: <83sg7mggls.fsf@gnu.org> <83czymc8nq.fsf@gnu.org> <74b7a0a9-0eb3-7944-19d2-f72424ee72d7@dasyatidae.com> <83eeirfqbo.fsf@gnu.org> <87o8hvscfi.fsf@gmail.com> <8335z7fmnz.fsf@gnu.org> <87ft374axc.fsf@gmail.com> <83wnwjdwww.fsf@gnu.org> <87czyb2nvq.fsf@gmail.com> <83r1mqdwri.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39167"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rtt@dasyatidae.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 12 16:38:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzLkS-000A4W-LZ for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Jan 2021 16:38:20 +0100 Original-Received: from localhost ([::1]:42438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzLkQ-00049B-2s for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Jan 2021 10:38:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzLix-0003Dr-KX for emacs-devel@gnu.org; Tue, 12 Jan 2021 10:36:47 -0500 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:34691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzLiw-000281-1A; Tue, 12 Jan 2021 10:36:47 -0500 Original-Received: by mail-wr1-x430.google.com with SMTP id q18so2963475wrn.1; Tue, 12 Jan 2021 07:36:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=XIcoJyrb704WY7ts4m/w8v+NSEVkb8t6+1oFoDRwA0c=; b=PL0H6I+0BAUNEH7eTz31dVrxPbpfVy95wkZoSPEgnVLl4C8aeHFdgT+8/0pqdTfJqi gjgPIxoL+AxeT+Id4bGCEt168RahrmoaC8X4vXVZ+NzgE2fhvgkqRmgb6sDt+NIoWeIZ qYsUINGSgapKQW7cH82x1uXfLcalO5hEit3to9UVDYbC7pE0pR9XwOJs+yPR3dUzKzQG 9M3taAt0b0h+EwGuJU857WSA7Siw8OUBVcFL5Q2U7J8RK2VPjyq6GzIfobQyg/8Nb8s8 vXq1lS0mt2D3lUgWQNMioHDth0cA1JMis7Z38sPVOYLjSoBu4n5Px1fAcxmko+0dpSPT +BgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=XIcoJyrb704WY7ts4m/w8v+NSEVkb8t6+1oFoDRwA0c=; b=peJF5bWJBiH7amjJR5oYICb35Qg4Vih1WgFsDdBfdpsicGpEwywUy6EjZRWUC3qiKk 28h48kgBBgOtBow9/ZM2dDbcn82zv9KBGSEsHlXSlrPznL6XERPBR/74vKRDo5p14+NM Ad/AZxU8k5/FCTFbxmDk3RUukk5mfeQmVXl2516RHk//iJxvLhkRr0Oc83KEKBdKDBHJ lX7+Th7t5OKjPl9qe1CBRQWwSSYbRHNbr3myJ+hkzpTsqLQwDjXQvg/t5Z0W2t/H20bI LJbtFZPsMVqBiejwBQk1ctpkVwei9fMzjQ/b9K09wpt3U2OibWv9i5vdzqpm/0Wg8gt9 hMGA== X-Gm-Message-State: AOAM533YZ3T37K2iGWpsCeU2XPMQlZM1970i+5A7QJ7LgKtj5ri3idql P08QlxMmPR+72nIAaXzCcZxqolNErOE= X-Google-Smtp-Source: ABdhPJyviXyd3DrbGitQFnudU+s2aYeyS4auMJEOSw9/h5kyMLT8bgJTBGAbS5h7wegIQ806SSlZXw== X-Received: by 2002:a5d:4f10:: with SMTP id c16mr4871346wru.398.1610465803209; Tue, 12 Jan 2021 07:36:43 -0800 (PST) Original-Received: from rltb ([2a01:e34:ecfc:a861:69b6:6aaf:dbd3:8964]) by smtp.gmail.com with ESMTPSA id w21sm4426313wmi.45.2021.01.12.07.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 07:36:42 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <83r1mqdwri.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Jan 2021 17:01:53 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=rpluim@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262986 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: rtt@dasyatidae.com, emacs-devel@gnu.org >> Date: Mon, 11 Jan 2021 21:56:57 +0100 >>=20 >> > Tell me what to try, and I will show the results. TIA. >>=20 >> I=CA=BCve lost track of which tests were failing, but something like >> following. And if the 'dns-query' calls succeed but the >> network-lookup-address-info ones fail then we have a really messed up >> situation. > > You assume that a TCP connection to the DNS server there will succeed? > It doesn't, at least judging by the error message (dns.el has no debug > facilities, so it's hard to know better). > Perhaps UDP would work better... (sorry, couldn't resist) > So I think I will now stop wasting your time, and just give up on > having these tests avoid false negatives. > > But before I go! I guess at least one of the 2 offending tests, > i.e. this one: > > (ert-deftest lookup-family-specification () > "`network-lookup-address-info' should only accept valid family symbol= s." > (skip-unless (not (getenv "EMACS_HYDRA_CI"))) > (with-timeout (60 (ert-fail "Test timed out")) > (should-error (network-lookup-address-info "google.com" 'both)) > (should (network-lookup-address-info "google.com" 'ipv4)) > (when (featurep 'make-network-process '(:family ipv6)) > (should (network-lookup-address-info "google.com" 'ipv6))))) > > could use "localhost" instead of google.com, since it only tests the > input validity? It could indeed. 'lookup-google' further down repeats the lookups anyway. I=CA=BCll queue that up. Robert