From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Patch upstream Git for Elisp diff hunk headings Date: Fri, 12 Feb 2021 17:39:41 +0000 Message-ID: <87y2ftp4ma.fsf@tcd.ie> References: <87czx68y4i.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8341"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Adam Spiers , Protesilaos Stavrou , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 12 18:42:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAcSr-00023U-Uw for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Feb 2021 18:42:45 +0100 Original-Received: from localhost ([::1]:47796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAcSq-000835-T9 for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Feb 2021 12:42:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAcPz-0004yI-PS for emacs-devel@gnu.org; Fri, 12 Feb 2021 12:39:47 -0500 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:38283) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAcPx-000792-R7 for emacs-devel@gnu.org; Fri, 12 Feb 2021 12:39:47 -0500 Original-Received: by mail-wm1-x32e.google.com with SMTP id x4so369124wmi.3 for ; Fri, 12 Feb 2021 09:39:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yZaKBISQKf1w5P5FnohS7VIlFsX8MQKIGTRuLXEt8b4=; b=OwTLqbaxh6UMyB7++joK7TfXcpOoDzb1jZLBbAbsn6HsQBjcJtygCXrPYDfvPhlo+u woSB5QqNzbAQKGd+dgIQwAPezjlvZaGuUEvpwO7NKmHb3/EmhdCuvzQIqzmLo+YnTveA 0cyhJ6kf408lQUANZoPklhuB4fcyC/dfyJI2YHmrE/zmpgqzxZ5q/ENLVx+008xRJbZP G6TiMB8Ad1W8zsPk8UBW6vAdMgsgOjfvvuBdwsrnu4Sxb28osrM6LpA7R3FqMkBXt3I9 7LrUPMatXzyOoZSXMFnD57iNnboF0+zRv16KXjjdovNdJo60woXXwNfH1lg2o+1zMRUR Z5aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=yZaKBISQKf1w5P5FnohS7VIlFsX8MQKIGTRuLXEt8b4=; b=V/O9XgViA0RixokR14IeW87XLvhEQ+YHhym+s7OC1nPQIQHkPD8Ux0hFdZBS/3b+5W z+NQU1YcJTbukgCtnzRv6nBVgDF22Tvu7KGJ9Y9/P0Cb1MyY8mBo17gFheTn+eog1mhi 3KyOqCyUiTBUsAqyko8bHBsXpUiwyULiiPUCox9elpn+mhSX1b9ooUWA80sxb3VsYYLe JqD+W4zZcy95qhisV72gPI7xXkeKncJkVGzhxbpLIHULbLNFYpVCHUJ512/2YBIZq2S9 FkawyHVDUiiDX5PVp2T7ZiaZKSm25p7xVHk4NP2U3vX0qJtr+uaDVXQ1A+1BzenxRNo+ AFAg== X-Gm-Message-State: AOAM530FDzqXc9x/jF9YoZj0kauEaWTPKp+lN5U0S1wVOEW4+aqbycrt X+zIV60nsmVHYI8QQhH+mTgV3w== X-Google-Smtp-Source: ABdhPJx6YVdF9hdLbjnUMYHPdakUKoxghUGcujbpLhZjJsNDKn3XnNOov9NAb2yUeKTunQIj1EBb8A== X-Received: by 2002:a05:600c:4c11:: with SMTP id d17mr3770306wmp.86.1613151582813; Fri, 12 Feb 2021 09:39:42 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id u7sm11024177wrt.67.2021.02.12.09.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 09:39:42 -0800 (PST) In-Reply-To: (Stefan Kangas's message of "Thu, 11 Feb 2021 13:05:19 -0600") Received-SPF: none client-ip=2a00:1450:4864:20::32e; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264537 Archived-At: Stefan Kangas writes: > Adam Spiers writes: > >> While of course no one is claiming that this is technically correct in >> all cases, I don't think I can actually recall ever seeing a single >> instance of a top-level form which *was* indented. So presumably it's >> a good enough heuristic to be helpful in the vast majority of cases. >> Or at least it's more likely to be right than a heuristic which >> assumes that all top-level forms include "def" in the first symbol in >> the form, since the latter obviously fails in many common scenarios >> including the init files one mentioned above. > > (It also fails with `ert-deftest', and probably also other unit test > frameworks in popular use.) The current regexp doesn't fail on ert-deftest. -- Basil