From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Mon, 03 May 2021 01:18:09 +0300 Organization: LINKOV.NET Message-ID: <87y2cwhiti.fsf@mail.linkov.net> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <2599ffef-4f70-025c-5f9c-61b9ac94faf8@inventati.org> <87eefrbo9k.fsf@posteo.net> <7473b27b2b479f5686af@heytings.org> <87tuon9vf1.fsf@posteo.net> <20210403174508.xwr5uc36dzityitn@Ergus> <87wnsurdr7.fsf@gmail.com> <87fszij6to.fsf@mail.linkov.net> <87v98asulc.fsf@gmail.com> <87pmyimiwd.fsf@mail.linkov.net> <87bla11u5q.fsf@gmail.com> <87lf937hgk.fsf@mail.linkov.net> <87y2d1ksga.fsf@mail.linkov.net> <87r1it7zfw.fsf@gmail.com> <87v98466it.fsf@mail.linkov.net> <87bl9wcksv.fsf@gmail.com> <87tunnzqci.fsf@mail.linkov.net> <87bl9tmzun.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16692"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Philip Kaludercic , Gregory Heytings , Ergus , Manuel Uberti , emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 03 00:32:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldKdA-0004Ee-QN for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 00:32:04 +0200 Original-Received: from localhost ([::1]:46012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldKd9-0000TP-Ta for ged-emacs-devel@m.gmane-mx.org; Sun, 02 May 2021 18:32:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldKcc-0008Uy-QB for emacs-devel@gnu.org; Sun, 02 May 2021 18:31:30 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:51491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldKca-0006nX-6N for emacs-devel@gnu.org; Sun, 02 May 2021 18:31:30 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 83CA060003; Sun, 2 May 2021 22:31:23 +0000 (UTC) In-Reply-To: <87bl9tmzun.fsf@gmail.com> (Augusto Stoffel's message of "Sun, 02 May 2021 08:09:04 +0200") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268786 Archived-At: > 1. Since you probably want to remove the ugly `with-isearch-suspended' > eventually, the local mode will not only be on by default, it will be > the only alternative. Should then `isearch-buffer-local' be > double-dashed, so it too can be removed? It could be removed in later releases, indeed. But OTOH, until it's removed, naming a user option with double-dashes is not allowed. > 2. In edit mode, when I delete a character, the search doesn't backtrack > to the barrier. It's the same undesirable behavior described in > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46469. In isearch-mb, > the post-command-hook contains > > (goto-char isearch-barrier) > (setq isearch-adjusted t isearch-success t) > > for to fix that. Thanks, this should be added to the patch. > 3. The after change hook should call `isearch-update' instead of > `isearch-search-and-update' after `previous-history-element' and few > other commands. In isearch-mb I use a symbol property to keep track > of this. Thanks, it seems many solutions could be taken from isearch-mb to isearch.el. > 4. Every time one types a character in the minibuffer, there is a > visible flicker in the cursor. In isearch-mb I've let-bound > `inhibit-redisplay' to t in a couple of places and it solved this > problem. I wonder if there's a better solution. Maybe a flicker is caused by isearch-message? > 5. The command `isearch-forward-exit-minibuffer' should eventually be > removed, and instead `isearch-repeat-forward' should work in both > cases (this will probably be implemented with the help of a new > macro). The reason for this is that there is at least a dozen other > Isearch commands that make sense in the minibuffer map as well > (toggling modes, quitting and entering query-replace, and so on), and > it would be annoying to write a minibuffer variant for each of them. This is the part where I don't yet have an idea how to handle all isearch commands from the minibuffer without using a macro to implement their duplicates to be callable from the minibuffer. > 6. Why is there the option to specify an `isearch-new-message' in > `with-isearch-suspended'? I've never seen any valid value other than > `(mapconcat 'isearch-text-char-description isearch-string "")', which, > by the way, repeats at several places in isearch.el This is just to handle existing uses of with-isearch-suspended that currently set isearch-new-message, i.e. this could be changed later. >> And here is a patch for updating the search from the minibuffer. This allows >> to implement https://lists.gnu.org/archive/html/emacs-devel/2020-01/msg00447.html >> to control the search from the minibuffer. But I'm not sure if the same option >> isearch-buffer-local should enable this mode: > > I still don't understand why Isearch has to be so stringent about > backward compatibility of key sequences. But I don't care about the > edit mode per se. I only care about an alternative mode where `C-s' > immediately goes to the minibuffer, and exiting the minibuffer ends the > search. In such a new mode isearch-edit-string could be called at the end of isearch-mode.