From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: native-comp *Warnings* buffer Date: Sat, 15 May 2021 21:15:26 -0700 Message-ID: <87y2cfwbz5.fsf@ericabrahamsen.net> References: <87k0o2z9pr.fsf@ericabrahamsen.net> <83y2chzvxw.fsf@gnu.org> <87czttxquo.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4781"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 16 06:17:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1li8DE-00014q-V0 for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 06:17:09 +0200 Original-Received: from localhost ([::1]:59084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1li8DD-0002r7-0G for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 00:17:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1li8Bn-0001eP-0b for emacs-devel@gnu.org; Sun, 16 May 2021 00:15:43 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:34218 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1li8Bk-0002dl-US; Sun, 16 May 2021 00:15:38 -0400 Original-Received: from localhost (c-71-197-184-122.hsd1.wa.comcast.net [71.197.184.122]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BBA1DFED1B; Sun, 16 May 2021 04:15:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1621138528; bh=4lnlopMLFoexkFbd7EJxbK6vqVRNF2VusiqcqYozd7g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MwYnn+cwKBJvSctE0r56H0qqgvdGG7SrUQ8PwdD9jV9huLD6Tp6logmA3QMAvJSGt AlpDRaCiG8GWjdDRnWIzd/0JpjvFKGoieOQLSaljArmIE2C0FIM1RrNDmuuT/IzZ2B NYR/XjzSSr1GmCXPmLG5qLIzqRBZdEmqXz62GgTU= In-Reply-To: (Richard Stallman's message of "Sat, 15 May 2021 01:33:14 -0400") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269323 Archived-At: --=-=-= Content-Type: text/plain Richard Stallman writes: > [[[ To any NSA and FBI agents reading my email: please consider ]]] > [[[ whether defending the US Constitution against all enemies, ]]] > [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > > I think "stealth" compilation performed opportunistically in the > > background should indeed not display any warnings (by default). > > I understand the reason for saying that, but... would this mean that a > compilation of that meaterial won't happen later? Is there a chance > that you'll never see the warnings that compilation generates? This wouldn't affect the actual compilation at all. It could affect whether the user sees the warnings or not, if we default to not popping up the *Warnings* buffer. They might still go looking for the buffer, or stumble upon it by accident, though. I've attached a patch that provides a 'silent option to `native-comp-async-report-warnings-errors'. In this patch the default is still t, though we could easily default to 'silent if that seems desirable. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Provide-a-silent-option-for-native-comp-asyncreport-.patch >From 01516b21e71862f3496e3a1f75bb86d436afaa3b Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sat, 15 May 2021 09:36:05 -0700 Subject: [PATCH] Provide a 'silent option for native-comp-asyncreport-warnings-errors * lisp/emacs-lisp/comp.el (native-comp-async-report-warnings-errors): Set to 'silent to log warnings, but not pop up the *Warnings* buffer. * lisp/emacs-lisp/comp.el (comp-accept-and-process-async-output): Check value. --- lisp/emacs-lisp/comp.el | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 3e7f17ef1c..8fa9dee1ed 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -148,8 +148,13 @@ native-comp-async-report-warnings-errors environment, it is more sensitive to such omissions, and might be unable to compile such Lisp source files correctly. -Set this variable to nil if these warnings annoy you." - :type 'boolean +Set this variable to nil to suppress warnings altogether, or to +the symbol `quiet' to log warnings but not pop up the *Warnings* +buffer." + :type '(choice + (const :tag "Do not report warnings" nil) + (const :tag "Report and display warnings" t) + (const :tag "Report but do not display warnings" 'silent)) :version "28.1") (defcustom native-comp-async-query-on-exit nil @@ -3874,14 +3879,18 @@ comp-last-scanned-async-output (defun comp-accept-and-process-async-output (process) "Accept PROCESS output and check for diagnostic messages." (if native-comp-async-report-warnings-errors - (with-current-buffer (process-buffer process) - (save-excursion - (accept-process-output process) - (goto-char (or comp-last-scanned-async-output (point-min))) - (while (re-search-forward "^.*?\\(?:Error\\|Warning\\): .*$" - nil t) - (display-warning 'comp (match-string 0))) - (setq comp-last-scanned-async-output (point-max)))) + (let ((warning-suppress-types + (if (eq native-comp-async-report-warnings-errors 'silent) + (cons '(comp) warning-suppress-types) + warning-suppress-types))) + (with-current-buffer (process-buffer process) + (save-excursion + (accept-process-output process) + (goto-char (or comp-last-scanned-async-output (point-min))) + (while (re-search-forward "^.*?\\(?:Error\\|Warning\\): .*$" + nil t) + (display-warning 'comp (match-string 0))) + (setq comp-last-scanned-async-output (point-max))))) (accept-process-output process))) (defun comp-run-async-workers () -- 2.31.1 --=-=-=--