unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tgbugs@gmail.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix hack-local-variables for find-file-literally with dos encoding
Date: Mon, 16 Aug 2021 14:53:18 +0200	[thread overview]
Message-ID: <87y291blfl.fsf@gnus.org> (raw)
In-Reply-To: <83lf518ter.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Aug 2021 15:29:16 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> More importantly, what about selective-display, which replaces
> newlines with \r's?  I think this replacement is for that use case.
>
> So perhaps the condition for the replacement should be
> selective-display?

Aha!  The initial revision of files.el had:

+(defun hack-local-variables (&optional force)
[...]
+	    ;; Look at next local variable spec.
+	    (if selective-display (re-search-forward "[\n\C-m]")
+	      (forward-line 1))

So the ^M stuff that remains in here may have nothing to do with CRLF
DOS stuff, but is something that's left over from code meant to deal
with selective display?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2021-08-16 12:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-15 21:23 [PATCH] Fix hack-local-variables for find-file-literally with dos encoding Tom Gillespie
2021-08-15 21:35 ` Tom Gillespie
2021-08-15 21:52 ` Lars Ingebrigtsen
2021-08-15 22:14   ` Lars Ingebrigtsen
2021-08-15 22:31     ` Tom Gillespie
2021-08-15 22:21   ` Tom Gillespie
2021-08-15 22:39     ` Tom Gillespie
2021-08-15 23:09       ` Tom Gillespie
2021-08-16 11:32         ` Eli Zaretskii
2021-08-16 12:01     ` Lars Ingebrigtsen
2021-08-16 12:06       ` Lars Ingebrigtsen
2021-08-16 12:29       ` Eli Zaretskii
2021-08-16 12:53         ` Lars Ingebrigtsen [this message]
2021-08-16 13:22           ` Eli Zaretskii
2021-08-16 17:44             ` Tom Gillespie
2021-08-16 17:49               ` Stefan Monnier
2021-08-16 18:09                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y291blfl.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=tgbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).